From: Pavel Machek <pavel@ucw.cz>
To: kernel list <linux-kernel@vger.kernel.org>,
Patrick Mochel <mochel@digitalimplant.org>
Subject: highmem handling again
Date: Sun, 8 Aug 2004 21:23:00 +0200 [thread overview]
Message-ID: <20040808192300.GA659@elf.ucw.cz> (raw)
Hi!
I agree that swsusp_free is not the right place to restore_highmem(),
but I can't find "right" place to do it... Best I could come up is
with is:
It did not work at the end of swsusp_resume, or at the end of
swsusp_restore, IIRC.
Pavel
--- clean-mm/kernel/power/disk.c 2004-07-28 23:39:49.000000000 +0200
+++ linux-mm/kernel/power/disk.c 2004-08-08 21:11:38.000000000 +0200
@@ -184,8 +187,11 @@
error = power_down(pm_disk_mode);
pr_debug("PM: Power down failed.\n");
}
- } else
+ } else {
+ extern int restore_highmem(void);
+ restore_highmem();
pr_debug("PM: Image restored successfully.\n");
+ }
swsusp_free();
Done:
finish();
--- clean-mm/kernel/power/swsusp.c 2004-07-28 23:39:49.000000000 +0200
+++ linux-mm/kernel/power/swsusp.c 2004-08-08 20:55:59.000000000 +0200
@@ -523,7 +523,7 @@
return 0;
}
-static int restore_highmem(void)
+int restore_highmem(void)
{
while (highmem_copy) {
struct highmem_page *save = highmem_copy;
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
next reply other threads:[~2004-08-08 19:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-08 19:23 Pavel Machek [this message]
2004-08-08 19:55 ` highmem handling again Sam Ravnborg
2004-08-08 20:01 ` Pavel Machek
2004-08-09 8:27 ` Nigel Cunningham
2004-08-09 8:46 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040808192300.GA659@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@digitalimplant.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox