From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266189AbUHIHBW (ORCPT ); Mon, 9 Aug 2004 03:01:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266194AbUHIHBW (ORCPT ); Mon, 9 Aug 2004 03:01:22 -0400 Received: from mail.kroah.org ([69.55.234.183]:60079 "EHLO perch.kroah.org") by vger.kernel.org with ESMTP id S266189AbUHIHBV (ORCPT ); Mon, 9 Aug 2004 03:01:21 -0400 Date: Sun, 8 Aug 2004 23:45:24 -0700 From: Greg KH To: John Rose Cc: lkml , Hotplug List Subject: Re: [Pcihpd-discuss] struct pci_bus, no release() function? Message-ID: <20040809064524.GD13690@kroah.com> References: <1091477728.23381.24.camel@sinatra.austin.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1091477728.23381.24.camel@sinatra.austin.ibm.com> User-Agent: Mutt/1.5.6i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 02, 2004 at 03:15:28PM -0500, John Rose wrote: > At probe time, pci_scan_bus_parented() allocates and registers a struct > device for each PCI bus it scans. This generic device structure never > gets assigned a "release" function. > > Attempts to unregister such a PCI Bus at runtime result in a kernel > message like: > Device 'pci0001:00' does not have a release() function, it is broken and > must be fixed. You're right, that should be fixed. Care to send a patch? Should just be a 1 line change. You can tell no one else has tried to remove a root bus device before... > Are architectures free to assign their own release function for > "devices" associated with struct pci_bus? Why would they want to? It should just be set to pci_release_dev, like all other struct pci_dev devices are, right? > If so, does this have to happen at boot, or can it happen right before > the remove? Heh, you can't assign a release function after it is needed :) thanks, greg k-h