Re: [0/3]kprobes-base-268-rc3.patch

Andi Kleen
2004-08-06T15:17:55Z

On Fri, Aug 06, 2004 at 06:07:57PM +0530, Prasanna S Panchamukhi wrote:
> Hi Andi,
>
> Please find the exception notifiers patch for i386 architecture ported from
> x86_64 architecture.
> Also I would like to mention that:
>
> Earlier Stephen Hemminger ported notifiers to i386. The reason to drop the patch was
> was, there were some bad interaction issues with using the hooks for NMI (trap
> 2), locking and oprofile.
>
> Please review and provide your comments.

The register_i386... names look ugly. Leave the i386 out.

Other than that it looks ok.

Thanks,

Is it good enough for kprobes?

-Andi