Re: [RFC] Host Virtual Serial Interface driver

[Hollis Blanchard <hollisb@us.ibm.com>]

On Monday 09 August 2004 14:00, Sam Ravnborg wrote:
> On Mon, Aug 09, 2004 at 01:51:49PM -0500, Hollis Blanchard wrote:
> > > pr_debug is a noop if DEBUG is not defined. Make dump_hex, dump_packet
> > > be a noop also and you get rid of several #ifdef in the code.
> >
> > I'd like to do that, but notice that dump_hex() is called from
> > dump_packet() from hvsi_recv_response() (and I've just made
> > hvsi_recv_control() the same). Even with debug disabled, I'd like to be
> > able to dump a whole packet if I get confused...
>
> Make a small wrapper that becomes noop in non-debug case,
> and use the real one where you do not care about DEBUG.

Ah sure, like this:

#ifdef DEBUG
#define dbg_dump_packet(packet) dump_packet(packet)
#define dbg_dump_hex(data, len) dump_hex(data, len)
#else
#define dbg_dump_packet(packet)
#define dbg_dump_hex(data, len)
#endif

... and then replace the in-DEBUG callers. I like it, thanks.

-- 
Hollis Blanchard
IBM Linux Technology Center