2.6.7-rc3-mm2 inlining failures.

2.6.7-rc3-mm2 inlining failures.

[Dave Jones]

arch/i386/mach-generic/summit.c: In function `send_IPI_all':
include/asm/mach-summit/mach_ipi.h:4: sorry, unimplemented: inlining failed in call to 'send_IPI_mask_sequence': function body not available
arch/i386/mach-generic/summit.c:8: sorry, unimplemented: called from here
make[1]: *** [arch/i386/mach-generic/summit.o] Error 1
make: *** [arch/i386/mach-generic] Error 2

arch/i386/mach-generic/bigsmp.c: In function `send_IPI_all':
include/asm/mach-bigsmp/mach_ipi.h:4: sorry, unimplemented: inlining failed in call to 'send_IPI_mask_sequence': function body not available
arch/i386/mach-generic/bigsmp.c:8: sorry, unimplemented: called from here
make[1]: *** [arch/i386/mach-generic/bigsmp.o] Error 1
make: *** [arch/i386/mach-generic] Error 2

arch/i386/mach-generic/es7000.c: In function `send_IPI_all':
include/asm/mach-es7000/mach_ipi.h:4: sorry, unimplemented: inlining failed in call to 'send_IPI_mask_sequence': function body not available
arch/i386/mach-generic/es7000.c:8: sorry, unimplemented: called from here
make[1]: *** [arch/i386/mach-generic/es7000.o] Error 1
make: *** [arch/i386/mach-generic] Error 2


gcc version 3.4.1 20040714 (Red Hat 3.4.1-7)


--- linux-2.6.7/include/asm/mach-summit/mach_ipi.h~	2004-08-09 19:30:02.639882888 +0100
+++ linux-2.6.7/include/asm/mach-summit/mach_ipi.h	2004-08-09 19:30:07.432154352 +0100
@@ -1,7 +1,7 @@
 #ifndef __ASM_MACH_IPI_H
 #define __ASM_MACH_IPI_H
 
-inline void send_IPI_mask_sequence(cpumask_t mask, int vector);
+void send_IPI_mask_sequence(cpumask_t mask, int vector);
 
 static inline void send_IPI_mask(cpumask_t mask, int vector)
 {
--- linux-2.6.7/include/asm/mach-bigsmp/mach_ipi.h~	2004-08-09 19:30:18.660447392 +0100
+++ linux-2.6.7/include/asm/mach-bigsmp/mach_ipi.h	2004-08-09 19:30:21.603000056 +0100
@@ -1,7 +1,7 @@
 #ifndef __ASM_MACH_IPI_H
 #define __ASM_MACH_IPI_H
 
-inline void send_IPI_mask_sequence(cpumask_t mask, int vector);
+void send_IPI_mask_sequence(cpumask_t mask, int vector);
 
 static inline void send_IPI_mask(cpumask_t mask, int vector)
 {
--- linux-2.6.7/include/asm/mach-es7000/mach_ipi.h~	2004-08-09 19:30:43.086734032 +0100
+++ linux-2.6.7/include/asm/mach-es7000/mach_ipi.h	2004-08-09 19:30:45.324393856 +0100
@@ -1,7 +1,7 @@
 #ifndef __ASM_MACH_IPI_H
 #define __ASM_MACH_IPI_H
 
-inline void send_IPI_mask_sequence(cpumask_t mask, int vector);
+void send_IPI_mask_sequence(cpumask_t mask, int vector);
 
 static inline void send_IPI_mask(cpumask_t mask, int vector)
 {

Re: 2.6.7-rc3-mm2 inlining failures.

[Adrian Bunk]

On Mon, Aug 09, 2004 at 07:32:01PM +0100, Dave Jones wrote:
> arch/i386/mach-generic/summit.c: In function `send_IPI_all':
> include/asm/mach-summit/mach_ipi.h:4: sorry, unimplemented: inlining failed in call to 'send_IPI_mask_sequence': function body not available
> arch/i386/mach-generic/summit.c:8: sorry, unimplemented: called from here
> make[1]: *** [arch/i386/mach-generic/summit.o] Error 1
> make: *** [arch/i386/mach-generic] Error 2
>...
> gcc version 3.4.1 20040714 (Red Hat 3.4.1-7)
> 
> 
> --- linux-2.6.7/include/asm/mach-summit/mach_ipi.h~	2004-08-09 19:30:02.639882888 +0100
> +++ linux-2.6.7/include/asm/mach-summit/mach_ipi.h	2004-08-09 19:30:07.432154352 +0100
> @@ -1,7 +1,7 @@
>  #ifndef __ASM_MACH_IPI_H
>  #define __ASM_MACH_IPI_H
>  
> -inline void send_IPI_mask_sequence(cpumask_t mask, int vector);
> +void send_IPI_mask_sequence(cpumask_t mask, int vector);
>  
>  static inline void send_IPI_mask(cpumask_t mask, int vector)
>  {
>...

I assume removing the inline from the actual function in 
arch/i386/kernel/smp.c is also required for correctness?

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed