* [PATCH 2.6] Remove spaces from MTD pci_driver.name field
@ 2004-08-10 4:37 Deepak Saxena
2004-08-10 11:37 ` Alan Cox
0 siblings, 1 reply; 2+ messages in thread
From: Deepak Saxena @ 2004-08-10 4:37 UTC (permalink / raw)
To: dwmw2; +Cc: linux-kernel
David,
Spaces in driver names show up as spaces in the sysfs tree.
While there is no documented requirement that spaces not
exist in sysfs paths, my understanding is that they are not
desired.
Please apply,
~Deepak
Signed-off-by: Deepak Saxena <dsaxena@plexity.net>
===== drivers/mtd/maps/pci.c 1.6 vs edited =====
--- 1.6/drivers/mtd/maps/pci.c Thu Jul 15 10:31:48 2004
+++ edited/drivers/mtd/maps/pci.c Mon Aug 9 18:06:34 2004
@@ -362,7 +362,7 @@
}
static struct pci_driver mtd_pci_driver = {
- .name = "MTD PCI",
+ .name = "MTD_PCI",
.probe = mtd_pci_probe,
.remove = __devexit_p(mtd_pci_remove),
.id_table = mtd_pci_ids,
===== drivers/mtd/maps/scb2_flash.c 1.4 vs edited =====
--- 1.4/drivers/mtd/maps/scb2_flash.c Thu Jul 15 10:31:48 2004
+++ edited/drivers/mtd/maps/scb2_flash.c Mon Aug 9 18:06:53 2004
@@ -229,7 +229,7 @@
};
static struct pci_driver scb2_flash_driver = {
- .name = "Intel SCB2 BIOS Flash",
+ .name = "Intel_SCB2_BIOS",
.id_table = scb2_flash_pci_ids,
.probe = scb2_flash_probe,
.remove = __devexit_p(scb2_flash_remove),
--
Deepak Saxena - dsaxena at plexity dot net - http://www.plexity.net/
"Unlike me, many of you have accepted the situation of your imprisonment and
will die here like rotten cabbages." - Number 6
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2.6] Remove spaces from MTD pci_driver.name field
2004-08-10 4:37 [PATCH 2.6] Remove spaces from MTD pci_driver.name field Deepak Saxena
@ 2004-08-10 11:37 ` Alan Cox
0 siblings, 0 replies; 2+ messages in thread
From: Alan Cox @ 2004-08-10 11:37 UTC (permalink / raw)
To: dsaxena; +Cc: dwmw2, Linux Kernel Mailing List
On Maw, 2004-08-10 at 05:37, Deepak Saxena wrote:
> - .name = "Intel SCB2 BIOS Flash",
> + .name = "Intel_SCB2_BIOS",
This not only remove spaces (arguable) it also changes other parts
of the naming.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-08-10 12:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-08-10 4:37 [PATCH 2.6] Remove spaces from MTD pci_driver.name field Deepak Saxena
2004-08-10 11:37 ` Alan Cox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).