public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Roger Luethi <rl@hellgate.ch>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux 2.6.8-rc4 [RESEND] via-rhine: Really call rhine_power_init()
Date: Tue, 10 Aug 2004 10:33:50 +0200	[thread overview]
Message-ID: <20040810083350.GA23771@k3.hellgate.ch> (raw)
In-Reply-To: <Pine.LNX.4.58.0408091958450.1839@ppc970.osdl.org>

This is my third and last attempt to get this fix merged for 2.6.8.

Without this patch, mainline via-rhine cannot wake the chip if some other
driver puts it to D3. The problem has hit quite a few people already.

This is a fix for the heisenbug with via-rhine refusing to work
sometimes. Patch "[9/9] Restructure reset code" contained a change made
necessary by patch [8/9]. Mainline merged [8/9] for 2.6.8 and is still
missing the fix, while -mm got it with [9/9].

Jesper Juhl provided crucial test data when no one else was able to
reproduce the symptoms.

Roger

Signed-off-by: Roger Luethi <rl@hellgate.ch>

--- tmp/drivers/net/via-rhine.c.00_broken	2004-07-29 13:58:17.000000000 +0200
+++ tmp/drivers/net/via-rhine.c	2004-07-30 15:12:36.656007543 +0200
@@ -748,6 +748,8 @@ static int __devinit rhine_init_one(stru
 	}
 #endif /* USE_MMIO */
 	dev->base_addr = ioaddr;
+	rp = netdev_priv(dev);
+	rp->quirks = quirks;
 
 	rhine_power_init(dev);
 
@@ -792,10 +794,8 @@ static int __devinit rhine_init_one(stru
 
 	dev->irq = pdev->irq;
 
-	rp = netdev_priv(dev);
 	spin_lock_init(&rp->lock);
 	rp->pdev = pdev;
-	rp->quirks = quirks;
 	rp->mii_if.dev = dev;
 	rp->mii_if.mdio_read = mdio_read;
 	rp->mii_if.mdio_write = mdio_write;

  reply	other threads:[~2004-08-10  8:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-10  3:03 Linux 2.6.8-rc4 Linus Torvalds
2004-08-10  8:33 ` Roger Luethi [this message]
2004-08-10 14:34   ` Linux 2.6.8-rc4 [RESEND] via-rhine: Really call rhine_power_init() Lee Revell
2004-08-13  4:45   ` Lee Revell
2004-08-13  8:44     ` Roger Luethi
2004-08-13 15:34     ` Linus Torvalds
2004-08-13 17:40       ` Lee Revell
2004-08-13 22:06       ` Lee Revell
2004-08-16 12:45       ` Patrick McFarland
2004-08-10 17:37 ` Linux 2.6.8-rc4 (compile stats) John Cherry
2004-08-10 18:39 ` [patch] 2.6.8-rc4: compile error with gcc 2.95 Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040810083350.GA23771@k3.hellgate.ch \
    --to=rl@hellgate.ch \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox