Re: [PATCH] Device class reference counting

[Thomas Koeller <thomas.koeller@baslerweb.com>]

On Friday 06 August 2004 21:47, Greg KH wrote:
> On Fri, Aug 06, 2004 at 11:43:47AM +0200, Thomas Koeller wrote:
> > Sorry,
> >
> > seems the patch got messsed up somehow, so I am
> > resending it:
>
> This patch looks good.  But it has the tabs stripped out of it, and no
> Signed-off-by: line.  Care to resend it with that fixed up?
>
> thanks,
>
> greg k-h

Hi greg,

here's the patch again, re-created against 2.6.8-rc3.
This time I even managed to read
Documentation/SubmittingPatches ;-)

The tabs are all there, if they are stripped again somewhere
along the way, it is beyond my control. If this should happen,
could you fix that on your side?

thanks,
Thomas



Signed-off-by: Thomas Koeller <thomas.koeller@baslerweb.com>

--- linux-2.6.8-rc3-orig/drivers/base/class.c	2004-08-07 12:19:01.000000000 +0200
+++ linux-2.6.8-rc3/drivers/base/class.c	2004-08-07 12:27:32.112631077 +0200
@@ -349,15 +349,20 @@ void class_device_initialize(struct clas
 
 int class_device_add(struct class_device *class_dev)
 {
-	struct class * parent;
+	struct class * parent = NULL;
 	struct class_interface * class_intf;
 	int error;
 
 	class_dev = class_device_get(class_dev);
-	if (!class_dev || !strlen(class_dev->class_id))
+	if (!class_dev)
 		return -EINVAL;
 
-	parent = class_get(class_dev->class);
+	if (!strlen(class_dev->class_id)) {
+		error = -EINVAL;
+		goto register_done;
+	}
+
+ 	parent = class_get(class_dev->class);
 
 	pr_debug("CLASS: registering class device: ID = '%s'\n",
 		 class_dev->class_id);

-- 
--------------------------------------------------

Thomas Koeller, Software Development
Basler Vision Technologies

thomas dot koeller at baslerweb dot com
http://www.baslerweb.com

==============================