Re: 2.6.8-rc4-mm1: legacy_va_layout compile error with SYSCTL=n

William Lee Irwin III
2004-08-11T22:50:48Z

On Thu, Aug 12, 2004 at 12:18:25AM +0200, Adrian Bunk wrote:
>> This patch breaks compilation with CONFIG_SYSCTL=n:
>> <-- snip -->
>> ...
>> LD .tmp_vmlinux1
>> arch/i386/mm/built-in.o(.text+0x1cd6): In function `arch_pick_mmap_layout':
>> : undefined reference to `sysctl_legacy_va_layout'
>> make: *** [.tmp_vmlinux1] Error 1
>> <-- snip -->

On Wed, Aug 11, 2004 at 03:33:53PM -0700, William Lee Irwin III wrote:
> Does this help?

Hmm, looks like there's a hugetlb warning too.

Index: mm1-2.6.8-rc4/mm/hugetlb.c
===================================================================
--- mm1-2.6.8-rc4.orig/mm/hugetlb.c 2004-08-10 23:00:25.100832480 -0700
+++ mm1-2.6.8-rc4/mm/hugetlb.c 2004-08-11 15:30:37.473778920 -0700
@@ -163,6 +163,7 @@
}
#endif

+#ifdef CONFIG_SYSCTL
static unsigned long set_max_huge_pages(unsigned long count)
{
while (count > nr_huge_pages) {
@@ -188,7 +189,6 @@
return nr_huge_pages;
}

-#ifdef CONFIG_SYSCTL
int hugetlb_sysctl_handler(struct ctl_table *table, int write,
struct file *file, void __user *buffer,
size_t *length, loff_t *ppos)