public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@fs.tum.de>
To: Tom Vier <tmv@comcast.net>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	greg@kroah.com
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: [patch] 2.6.8-rc4-mm1: i2c-keywest.c compile error
Date: Wed, 11 Aug 2004 13:35:24 +0200	[thread overview]
Message-ID: <20040811113523.GD26174@fs.tum.de> (raw)
In-Reply-To: <20040811001255.GA14402@zero>

On Tue, Aug 10, 2004 at 08:12:55PM -0400, Tom Vier wrote:
> 
> drivers/i2c/busses/i2c-keywest.c: In function `__check_probe':
> drivers/i2c/busses/i2c-keywest.c:94: error: `probe' undeclared (first use in this function)
> drivers/i2c/busses/i2c-keywest.c:94: error: (Each undeclared identifier is reported only once
> drivers/i2c/busses/i2c-keywest.c:94: error: for each function it appears in.)
> drivers/i2c/busses/i2c-keywest.c: At top level:
> drivers/i2c/busses/i2c-keywest.c:94: error: `probe' undeclared here (not in a function)
> drivers/i2c/busses/i2c-keywest.c:94: error: initializer element is not constant
> drivers/i2c/busses/i2c-keywest.c:94: error: (near initialization for `__param_probe.arg')
> drivers/i2c/busses/i2c-keywest.c:96: error: `probe' used prior to declaration
> make[3]: *** [drivers/i2c/busses/i2c-keywest.o] Error 1
>...

Thanks for this report.

The (untested) patch below should fix it.

> Tom Vier <tmv@comcast.net>

cu
Adrian




Signed-off-by: Adrian Bunk <bunk@fs.tum.de>

--- linux-2.6.8-rc4-mm1-full/drivers/i2c/busses/i2c-keywest.c.old	2004-08-11 13:28:39.000000000 +0200
+++ linux-2.6.8-rc4-mm1-full/drivers/i2c/busses/i2c-keywest.c	2004-08-11 13:28:54.000000000 +0200
@@ -88,13 +88,13 @@
 };
 #endif /* DEBUG */
 
+static int probe;
+
 MODULE_AUTHOR("Benjamin Herrenschmidt <benh@kernel.crashing.org>");
 MODULE_DESCRIPTION("I2C driver for Apple's Keywest");
 MODULE_LICENSE("GPL");
 module_param(probe, bool, 0);
 
-static int probe;
-
 #ifdef POLLED_MODE
 /* Don't schedule, the g5 fan controller is too
  * timing sensitive


  reply	other threads:[~2004-08-11 11:35 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-10  7:21 2.6.8-rc4-mm1 Andrew Morton
2004-08-10 15:09 ` 2.6.8-rc4-mm1 doesn't boot Adrian Bunk
2004-08-10 15:59   ` Bjorn Helgaas
2004-08-10 17:32     ` Adrian Bunk
2004-08-10 22:46       ` Bjorn Helgaas
2004-08-10 23:56         ` Adrian Bunk
2004-08-11 20:33           ` Bjorn Helgaas
2004-08-11 23:23             ` Adrian Bunk
2004-08-11  9:56         ` Alan Cox
2004-08-10 16:37 ` 2.6.8-rc4-mm1 Jesse Barnes
2004-08-10 21:20   ` 2.6.8-rc4-mm1 William Lee Irwin III
2004-08-10 22:39     ` 2.6.8-rc4-mm1 Robert Picco
2004-08-10 22:28       ` 2.6.8-rc4-mm1 William Lee Irwin III
2004-08-10 22:30         ` 2.6.8-rc4-mm1 William Lee Irwin III
2004-08-10 22:43           ` 2.6.8-rc4-mm1 William Lee Irwin III
2004-08-10 22:45             ` 2.6.8-rc4-mm1 William Lee Irwin III
2004-08-10 23:03               ` 2.6.8-rc4-mm1 William Lee Irwin III
2004-08-10 23:38                 ` 2.6.8-rc4-mm1 William Lee Irwin III
2004-08-11  2:01                 ` 2.6.8-rc4-mm1 Jesse Barnes
2004-08-10 23:15       ` 2.6.8-rc4-mm1 William Lee Irwin III
2004-08-10 19:43 ` 2.6.8-rc4-mm1 (compile stats) John Cherry
2004-08-11  0:12 ` 2.6.8-rc4-mm1 Tom Vier
2004-08-11 11:35   ` Adrian Bunk [this message]
2004-08-11 22:14 ` [patch] 2.6.8-rc4-mm1: NMI changes don't compile with SYSCTL=n Adrian Bunk
2004-08-11 22:18 ` 2.6.8-rc4-mm1: legacy_va_layout compile error " Adrian Bunk
2004-08-11 22:33   ` William Lee Irwin III
2004-08-11 22:42     ` William Lee Irwin III
2004-08-11 22:46       ` William Lee Irwin III
2004-08-11 23:02     ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040811113523.GD26174@fs.tum.de \
    --to=bunk@fs.tum.de \
    --cc=akpm@osdl.org \
    --cc=benh@kernel.crashing.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tmv@comcast.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox