From: Adrian Bunk <bunk@fs.tum.de>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-net@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] net/seeq8005.c: small cleanups (fwd)
Date: Wed, 11 Aug 2004 21:21:59 +0200 [thread overview]
Message-ID: <20040811192159.GE26174@fs.tum.de> (raw)
In-Reply-To: <411A64AA.70902@pobox.com>
On Wed, Aug 11, 2004 at 02:25:46PM -0400, Jeff Garzik wrote:
>...
> >-static const char version[] =
> >- "seeq8005.c:v1.00 8/07/95 Hamish Coleman
> >(hamish@zot.apana.org.au)\n";
>...
> >- if (net_debug && version_printed++ == 0)
> >- printk(version);
>...
> This "small cleanup" appears to kill useful and working code.
I'd agree if this was a version number that was regularly updated.
But when is a 9 year old version tag useful?
> Jeff
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
prev parent reply other threads:[~2004-08-11 19:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-09 21:51 [2.6 patch] net/seeq8005.c: small cleanups (fwd) Adrian Bunk
2004-08-11 18:25 ` Jeff Garzik
2004-08-11 19:21 ` Adrian Bunk [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040811192159.GE26174@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox