From: William Lee Irwin III <wli@holomorphy.com>
To: Jeff Dike <jdike@addtoit.com>
Cc: akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] 2.6.8-rc4-mm1 - UML fixes
Date: Wed, 11 Aug 2004 20:30:12 -0700 [thread overview]
Message-ID: <20040812033012.GE11200@holomorphy.com> (raw)
In-Reply-To: <200408120415.i7C4FWJd010494@ccure.user-mode-linux.org>
On Thu, Aug 12, 2004 at 12:15:32AM -0400, Jeff Dike wrote:
> The patch below fixes a few UML-specific bugs not related to the rest of the
> kernel
> a bogus error return and some formatting in the fork code
> correct calculation of task.thread.kernel_stack
> remove a bogus panic
> a couple of fixes to allow UML to boot in the presence of exec-shield
[...]
> p->thread.kernel_stack =
> - (unsigned long) p->thread_info + THREAD_SIZE;
> + (unsigned long) p->thread_info + 2 * PAGE_SIZE;
> return(CHOOSE_MODE_PROC(copy_thread_tt, copy_thread_skas, nr,
> clone_flags, sp, stack_top, p, regs));
Out of curiosity, why are you allocating 4*PAGE_SIZE for the stack if
you're only going to use 2*PAGE_SIZE of it? I saw no other users for
the rest of ->thread_info offhand.
-- wli
next prev parent reply other threads:[~2004-08-12 3:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-12 4:15 [PATCH 3/3] 2.6.8-rc4-mm1 - UML fixes Jeff Dike
2004-08-12 3:30 ` William Lee Irwin III [this message]
2004-08-12 5:41 ` Jeff Dike
2004-08-12 6:50 ` William Lee Irwin III
2004-08-12 16:56 ` Jeff Dike
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040812033012.GE11200@holomorphy.com \
--to=wli@holomorphy.com \
--cc=akpm@osdl.org \
--cc=jdike@addtoit.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox