Re: [PATCH 1/3] 2.6.8-rc4-mm1 - Fix UML build

Andrew Morton
2004-08-17T18:28:18Z

Jeff Dike <jdike@addtoit.com> wrote:
>
> akpm@osdl.org said:
> > Thanks. Where do we stand now with getting all this stuff merged up?
> > Are the patches in -mm suitable? Did the controversial blockdev stuff
> > get cleaned up? (it looks like it did...).
>
> Not really, the code is still there but it's not built. Below is a patch
> which removes it totally.

Thanks.

> I also have to get rid of ghash.h and fix some inappropriate intimacy between
> one of the drivers and VFS.

OK.

> I'd also wouldn't mind breaking up the big UML patch into somewhat more sane
> pieces. Can I do something like break pieces off it, send them plus the
> smaller big patch, and have you subsititute them for the current big patch?

Feel free if you think there's some benefit in that.

> Is that preferable to dropping the current patches on Linus, or would you
> rather send him what you have, in more or less its current form, once it's
> been tidied up?

Frankly, when a subsystem gets this far out of date I don't think it
matters a lot - nobody has much hope of following all the changes anyway.
We'll just merge the megapatch on the assumption that Jeff knows what he's
doing, and that it's better than what we had before. You should have seen
the size of some of those MIPS patches ;)