public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Sam Ravnborg <sam@ravnborg.org>
To: "David S. Miller" <davem@redhat.com>
Cc: torvalds@osdl.org, akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH]: __crc_* symbols in System.map
Date: Thu, 12 Aug 2004 07:01:36 +0200	[thread overview]
Message-ID: <20040812050136.GA7246@mars.ravnborg.org> (raw)
In-Reply-To: <20040811205529.1ff86e9d.davem@redhat.com>

On Wed, Aug 11, 2004 at 08:55:29PM -0700, David S. Miller wrote:
> 
> Shouldn't we be grepping these things out of the System.map file?
> 
> For one thing, these can confuse readprofile.  It's algorithm is
> to start at _stext, then stop when it sees a line in the System.map
> which is not text (mode is one of 'T' 't' 'W' or 'w')
> 
> It will exit early if there are some intermixed __crc_* things in
> there (since they are are mode 'A').
> 
> For example, in my current sparc64 kernel I have this:
> 
> 00000000004cef80 t do_split
> 00000000004cf2a0 t add_dirent_to_buf
> 00000000004cf5a7 A __crc_init_special_inode
> 00000000004cf640 t make_indexed_dir
> 00000000004cf900 t ext3_add_entry
> 
> So no symbols after add_dirent_to_buf will be shown in the profiling
> output of readprofile.
> 
> So we should grep them out, right?  If so, here is a patch which
> implements that.

I have a patch in this area pending, it moves System.map generation
out of the top-level makefile. And btw simplifies the expression a bit.

iMy patches are only at linux-sam.bkbits.net/kbuild for now,
will post patches later this week.

Would it be an option to skip all 'A' symbols?

	Sam

  reply	other threads:[~2004-08-12  4:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-12  3:55 [PATCH]: __crc_* symbols in System.map David S. Miller
2004-08-12  5:01 ` Sam Ravnborg [this message]
2004-08-12  7:05   ` David S. Miller
2004-08-13 18:02     ` Sam Ravnborg
2004-08-13 18:10       ` Sam Ravnborg
2004-08-13 20:18         ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040812050136.GA7246@mars.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=akpm@osdl.org \
    --cc=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox