* [PATCH] Remove whitespace from ALI15x3 IDE driver name
@ 2004-08-12 18:54 Pekka Enberg
2004-08-12 16:04 ` Christoph Hellwig
0 siblings, 1 reply; 6+ messages in thread
From: Pekka Enberg @ 2004-08-12 18:54 UTC (permalink / raw)
To: B.Zolnierkiewicz; +Cc: linux-kernel
This patch removes whitespace from ALI15x3 IDE driver name that appears in the
sysfs directory. It is against 2.6.7.
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
alim15x3.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
Index: linux-2.6.7-pe/drivers/ide/pci/alim15x3.c
===================================================================
--- linux-2.6.7-pe.orig/drivers/ide/pci/alim15x3.c 2004-08-05 17:28:15.000000000 +0000
+++ linux-2.6.7-pe/drivers/ide/pci/alim15x3.c 2004-08-12 16:45:22.774205576 +0000
@@ -893,7 +893,7 @@
MODULE_DEVICE_TABLE(pci, alim15x3_pci_tbl);
static struct pci_driver driver = {
- .name = "ALI15x3 IDE",
+ .name = "ALI15x3_IDE",
.id_table = alim15x3_pci_tbl,
.probe = alim15x3_init_one,
};
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] Remove whitespace from ALI15x3 IDE driver name
2004-08-12 18:54 [PATCH] Remove whitespace from ALI15x3 IDE driver name Pekka Enberg
@ 2004-08-12 16:04 ` Christoph Hellwig
2004-08-12 19:19 ` Pekka Enberg
2004-08-12 19:55 ` Alan Cox
0 siblings, 2 replies; 6+ messages in thread
From: Christoph Hellwig @ 2004-08-12 16:04 UTC (permalink / raw)
To: Pekka Enberg; +Cc: B.Zolnierkiewicz, linux-kernel
On Thu, Aug 12, 2004 at 06:54:38PM +0000, Pekka Enberg wrote:
> This patch removes whitespace from ALI15x3 IDE driver name that appears in the
> sysfs directory. It is against 2.6.7.
You jnow that this breaks every tool that knew of the names so far? E.g.
Debian mkinitrd (now has a patch to deal with both the whitespace and
non-whitespace variants) and probably quite a few installers out there.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Remove whitespace from ALI15x3 IDE driver name
2004-08-12 16:04 ` Christoph Hellwig
@ 2004-08-12 19:19 ` Pekka Enberg
2004-08-12 19:55 ` Alan Cox
1 sibling, 0 replies; 6+ messages in thread
From: Pekka Enberg @ 2004-08-12 19:19 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: B.Zolnierkiewicz, linux-kernel
Hi Christoph,
On Thu, Aug 12, 2004 at 06:54:38PM +0000, Pekka Enberg wrote:
> > This patch removes whitespace from ALI15x3 IDE driver name that appears in the
> > sysfs directory. It is against 2.6.7.
On Thu, 2004-08-12 at 16:04, Christoph Hellwig wrote:
> You jnow that this breaks every tool that knew of the names so far? E.g.
> Debian mkinitrd (now has a patch to deal with both the whitespace and
> non-whitespace variants) and probably quite a few installers out there.
Sorry, I did not know that. I only booted to my Gentoo box with it. I
saw similar patches go into other PCI drivers which is why I thought it
was appropriate.
Pekka
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Remove whitespace from ALI15x3 IDE driver name
2004-08-12 16:04 ` Christoph Hellwig
2004-08-12 19:19 ` Pekka Enberg
@ 2004-08-12 19:55 ` Alan Cox
2004-08-12 21:33 ` Deepak Saxena
1 sibling, 1 reply; 6+ messages in thread
From: Alan Cox @ 2004-08-12 19:55 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Pekka Enberg, Bartlomiej Zolnierkiewicz,
Linux Kernel Mailing List
On Iau, 2004-08-12 at 17:04, Christoph Hellwig wrote:
> On Thu, Aug 12, 2004 at 06:54:38PM +0000, Pekka Enberg wrote:
> > This patch removes whitespace from ALI15x3 IDE driver name that appears in the
> > sysfs directory. It is against 2.6.7.
>
> You jnow that this breaks every tool that knew of the names so far? E.g.
> Debian mkinitrd (now has a patch to deal with both the whitespace and
> non-whitespace variants) and probably quite a few installers out there.
Greg okayed a pile of other related changes including some that were not
just white space to _ but changed the actual string. So you may want to
take it up with Greg rather than Pekka who is just filling in one that
was missed
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] Remove whitespace from ALI15x3 IDE driver name
2004-08-12 19:55 ` Alan Cox
@ 2004-08-12 21:33 ` Deepak Saxena
2004-08-15 18:09 ` Christoph Hellwig
0 siblings, 1 reply; 6+ messages in thread
From: Deepak Saxena @ 2004-08-12 21:33 UTC (permalink / raw)
To: Alan Cox
Cc: Christoph Hellwig, Pekka Enberg, Bartlomiej Zolnierkiewicz,
Linux Kernel Mailing List
On Aug 12 2004, at 20:55, Alan Cox was caught saying:
> On Iau, 2004-08-12 at 17:04, Christoph Hellwig wrote:
> > On Thu, Aug 12, 2004 at 06:54:38PM +0000, Pekka Enberg wrote:
> > > This patch removes whitespace from ALI15x3 IDE driver name that appears in the
> > > sysfs directory. It is against 2.6.7.
> >
> > You jnow that this breaks every tool that knew of the names so far? E.g.
> > Debian mkinitrd (now has a patch to deal with both the whitespace and
> > non-whitespace variants) and probably quite a few installers out there.
>
> Greg okayed a pile of other related changes including some that were not
> just white space to _ but changed the actual string. So you may want to
> take it up with Greg rather than Pekka who is just filling in one that
> was missed
Not having touched installer code, can someone enlighten me on
why the installer would break with 's/ /_' or any other change
to driver name?
~Deepak
--
Deepak Saxena - dsaxena at plexity dot net - http://www.plexity.net/
"Unlike me, many of you have accepted the situation of your imprisonment and
will die here like rotten cabbages." - Number 6
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2004-08-15 18:10 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-08-12 18:54 [PATCH] Remove whitespace from ALI15x3 IDE driver name Pekka Enberg
2004-08-12 16:04 ` Christoph Hellwig
2004-08-12 19:19 ` Pekka Enberg
2004-08-12 19:55 ` Alan Cox
2004-08-12 21:33 ` Deepak Saxena
2004-08-15 18:09 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).