From: Jens Axboe <axboe@suse.de>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Alan Cox <alan@www.pagan.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: SG_IO and security
Date: Fri, 13 Aug 2004 08:59:03 +0200 [thread overview]
Message-ID: <20040813065902.GB2321@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.58.0408121705050.1839@ppc970.osdl.org>
On Thu, Aug 12 2004, Linus Torvalds wrote:
>
>
> On Thu, 12 Aug 2004, Alan Cox wrote:
> > > >
> > > > Hmm.. This still allows the old "junk" commands (SCSI_IOCTL_SEND_COMMAND).
> >
> > That uses sg_io() so gets caught as well unless I screwed up following
> > the code paths.
>
> No, while the cdrom_ioctl thing does use sg_io, the really old and
> horrible sg_scsi_ioctl thing does it's own commands by hand.
>
> I don't know why. I get the feeling that it _should_ use sg_io().
While that does make sense, it would be more code to fold them together
than what is currently there. SCSI_IOCTL_SEND_COMMAND is really
horrible, the person inventing that API should be subject to daily
public ridicule.
--
Jens Axboe
next prev parent reply other threads:[~2004-08-13 6:59 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-12 12:17 SG_IO and security Alan Cox
2004-08-12 16:39 ` Linus Torvalds
2004-08-12 16:45 ` Linus Torvalds
2004-08-12 16:55 ` Jeff Garzik
2004-08-12 17:01 ` Jeff Garzik
2004-08-12 17:02 ` Linus Torvalds
2004-08-12 17:13 ` Jeff Garzik
2004-08-12 19:22 ` Kai Makisara
2004-08-13 19:25 ` Peter Jones
2004-08-13 19:37 ` Jeff Garzik
2004-08-14 7:22 ` Kai Makisara
2004-08-14 15:33 ` Alan Cox
2004-08-16 22:24 ` Bill Davidsen
2004-08-16 22:00 ` Bill Davidsen
2004-08-12 17:06 ` Arjan van de Ven
2004-08-12 17:35 ` Jens Axboe
2004-08-12 18:29 ` Jens Axboe
2004-08-12 18:37 ` Jeff Garzik
2004-08-12 18:43 ` Jens Axboe
2004-08-12 18:45 ` Christoph Hellwig
2004-08-12 18:48 ` Jens Axboe
2004-08-12 20:19 ` Alan Cox
2004-08-12 20:16 ` Alan Cox
2004-08-12 22:51 ` Eric Lammerts
2004-08-13 0:09 ` Linus Torvalds
2004-08-13 6:59 ` Jens Axboe [this message]
2004-08-13 7:22 ` viro
2004-08-13 7:43 ` Arjan van de Ven
2004-08-13 7:46 ` Jens Axboe
2004-08-13 19:18 ` Jeff Garzik
2004-08-13 19:37 ` Linus Torvalds
2004-08-13 19:44 ` Jeff Garzik
2004-08-13 19:49 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040813065902.GB2321@suse.de \
--to=axboe@suse.de \
--cc=alan@www.pagan.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox