public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Patrick Mansfield <patmans@us.ibm.com>
To: Dominik Brodowski <linux@dominikbrodowski.de>,
	Rusty Russell <rusty@rustcorp.com.au>, Greg KH <greg@kroah.com>,
	lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [UPDATED PATCH 1/2] export module parameters in sysfs for modules _and_ built-in code
Date: Fri, 13 Aug 2004 10:08:45 -0700	[thread overview]
Message-ID: <20040813170845.GA25666@beaverton.ibm.com> (raw)
In-Reply-To: <20040802214710.GB7772@dominikbrodowski.de>

I finally tried this out, nice.

Is someone pushing it? I don't see it in 2.6.8-rc4-mm1.

-- Patrick Mansfield

On Mon, Aug 02, 2004 at 11:47:10PM +0200, Dominik Brodowski wrote:

> Create a new /sys top-level directory named "parameters", and make all
> to-be-sysfs-exported module parameters available as attributes to kobjects.
> Currently, only module parameters in _modules_ are exported in /sys/modules/,
> while those of "modules" built into the kernel can be set by the kernel command 
> line, but not read or set via sysfs.
> 
> For modules, a symlink
> 
> brodo@mondschein param $ ls -l /sys/module/ehci_hcd/ | grep param
> lrwxrwxrwx  1 brodo brodo    0  1. Aug 17:50 parameters -> ../../parameters/ehci_hcd
> 
> is added. Removal of double module parameters export for modules is sent in a second
> patch, so the diffstat
> 
>  include/linux/module.h      |    2
>  include/linux/moduleparam.h |   14 +
>  kernel/module.c             |   16 +
>  kernel/params.c             |  368 ++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 399 insertions(+), 1 deletion(-)
> 
> looks worse than it is.
> 
> Much of this work is based on the current code for modules only to be found in
> linux/kernel/module.c; many thanks to Rusty Russell for his code and his
> feedback!
> 
> Signed-off-by: Dominik Brodowski <linux@brodo.de>

  parent reply	other threads:[~2004-08-13 17:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-01 16:54 [RFC] [PATCH 1/2] export module parameters in sysfs for modules _and_ built-in code Dominik Brodowski
2004-08-02  5:59 ` Rusty Russell
2004-08-02 21:47   ` [UPDATED PATCH " Dominik Brodowski
2004-08-03  0:27     ` Rusty Russell
2004-08-13 17:08     ` Patrick Mansfield [this message]
2004-08-18 19:55     ` Martin Schlemmer
2004-08-20 13:46       ` Tonnerre
2004-08-29 13:14       ` Dominik Brodowski
2004-08-29 13:49         ` [UPDATED PATCH 1/2] export module parameters in sysfs for modules _and_ built-in code [u] Martin Schlemmer [c]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040813170845.GA25666@beaverton.ibm.com \
    --to=patmans@us.ibm.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@dominikbrodowski.de \
    --cc=rusty@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox