Re: [PATCH] [ix86,x86_64] cpu features.

Andi Kleen
2004-08-13T20:18:09Z

On Fri, Aug 13, 2004 at 07:02:45PM +0200, Pawe?? Sikora wrote:
> On Friday 13 of August 2004 18:11, Andi Kleen wrote:
> > Pawe? Sikora <pluto@pld-linux.org> writes:
> > > +++ linux-2.6.8-rc4/arch/i386/kernel/cpu/proc.c 2004-08-13
> > > 16:48:53.971370504 +0200 @@ -44,8 +44,8 @@
> > > NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL,
> > >
> > > /* Intel-defined (#2) */
> > > - "pni", NULL, NULL, "monitor", "ds_cpl", NULL, NULL, "tm2",
> > > - "est", NULL, "cid", NULL, NULL, NULL, NULL, NULL,
> > > + "sse3", NULL, NULL, "monitor", "ds_cpl", NULL, NULL, "est",
> > > + "tm2", NULL, "cid", NULL, NULL, NULL, "xtpr", NULL,
> >
> > You cannot just do the pni -> sse3 rename. That could break existing
> > applications that read /proc/cpuinfo and parse it. The only way would
> > be to add a new sse3 flag in addition to pni, but I guess that would
> > be not worth the ugly special case.
>
> Ok, it's now correct?

Can you please send a new diff, a diff of a diff is not very nice
to read.

-Andi