From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266896AbUHOU2e (ORCPT ); Sun, 15 Aug 2004 16:28:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266895AbUHOU2e (ORCPT ); Sun, 15 Aug 2004 16:28:34 -0400 Received: from mx1.redhat.com ([66.187.233.31]:59347 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S266891AbUHOU2X (ORCPT ); Sun, 15 Aug 2004 16:28:23 -0400 Date: Sun, 15 Aug 2004 16:27:22 -0400 From: Alan Cox To: Martin Schlemmer Cc: Alan Cox , linux-ide@vger.kernel.org, Linux Kernel Mailing Lists , torvalds@osdl.org Subject: Re: PATCH: fixup incomplete ident blocks on ITE raid volumes Message-ID: <20040815202722.GA29861@devserv.devel.redhat.com> References: <20040815144527.GA7983@devserv.devel.redhat.com> <1092601693.8976.140.camel@nosferatu.lan> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1092601693.8976.140.camel@nosferatu.lan> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 15, 2004 at 10:28:13PM +0200, Martin Schlemmer wrote: > > + } > > + id->cyls = 1 + id->lba_capacity_2 / (id->heads * id->sectors); > > + /* LBA28 is ok, DMA is ok, UDMA data is valid */ Change that to use sector_div() and it should be fine. My gcc didn't end up generating internal gcc library helpers for that so I didnt notice.