From: Pavel Machek <pavel@ucw.cz>
To: kernel list <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@zip.com.au>
Subject: Coding style: do_this(a,b) vs. do_this(a, b)
Date: Tue, 17 Aug 2004 12:38:52 +0200 [thread overview]
Message-ID: <20040817103852.GA18758@elf.ucw.cz> (raw)
Hi!
Coding style document is not consistent with itself on whether there
should be space after ","... This makes it standartize on ", " option.
Pavel
--- tmp/linux/Documentation/CodingStyle 2004-05-20 23:08:01.000000000 +0200
+++ linux/Documentation/CodingStyle 2004-06-06 00:27:11.000000000 +0200
@@ -356,11 +356,11 @@
Macros with multiple statements should be enclosed in a do - while block:
-#define macrofun(a,b,c) \
+#define macrofun(a, b, c) \
do { \
if (a == 5) \
- do_this(b,c); \
- } while (0)
+ do_this(b, c); \
+ } while(0)
Things to avoid when using macros:
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
next reply other threads:[~2004-08-17 10:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-17 10:38 Pavel Machek [this message]
2004-08-17 21:09 ` Coding style: do_this(a,b) vs. do_this(a, b) Fao, Sean
2004-08-17 21:14 ` Pavel Machek
2004-08-17 21:59 ` Frank van Maarseveen
2004-08-17 22:29 ` Andrew Morton
-- strict thread matches above, loose matches on Subject: below --
2004-08-17 11:51 Albert Cahalan
2004-08-17 16:07 ` Alexander Nyberg
2004-08-17 16:40 ` Pavel Machek
2004-08-17 17:07 ` Albert Cahalan
2004-08-17 20:00 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040817103852.GA18758@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=akpm@zip.com.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox