public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: dev_null@anet.ne.jp
Cc: a5497108@anet.ne.jp, marcelo.tosatti@cyclades.com,
	linux-kernel@vger.kernel.org
Subject: Re: TG3 doesn't work in kernel 2.4.27
Date: Tue, 17 Aug 2004 11:02:48 -0700	[thread overview]
Message-ID: <20040817110248.4c2f7cd8.davem@redhat.com> (raw)
In-Reply-To: <200408172129.AJH50391.692B5188@anet.ne.jp>

On Tue, 17 Aug 2004 21:30:06 +0900
Tetsuo Handa <a5497108@anet.ne.jp> wrote:

> I compiled as a UP kernel but it wasn't the cause.
> Also, I patched the above fix on 2.4.27-rc4 and
> compiled as a UP kernel, but didn't work.

Just add this patch, it will fix the problem but it
is not the nicest fix.  I'll work on a better one.

It just disables the new Sun code, and uses the old
fiber handling for 5704.

===== drivers/net/tg3.c 1.193 vs edited =====
--- 1.193/drivers/net/tg3.c	2004-08-16 18:01:30 -07:00
+++ edited/drivers/net/tg3.c	2004-08-16 18:46:58 -07:00
@@ -5415,13 +5398,13 @@
 	 * is enabled.
 	 */
 	tw32_f(MAC_LOW_WMARK_MAX_RX_FRAME, 2);
-
+#if 0
 	if (GET_ASIC_REV(tp->pci_chip_rev_id) == ASIC_REV_5704 &&
 	    (tp->tg3_flags2 & TG3_FLG2_PHY_SERDES)) {
 		/* Use hardware link auto-negotiation */
 		tp->tg3_flags2 |= TG3_FLG2_HW_AUTONEG;
 	}
-
+#endif
 	err = tg3_setup_phy(tp, 1);
 	if (err)
 		return err;

  parent reply	other threads:[~2004-08-17 18:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20040817110002.32088.38168.Mailman@linux.us.dell.com>
2004-08-17 12:30 ` TG3 doesn't work in kernel 2.4.27 Tetsuo Handa
2004-08-17 14:03   ` John W. Linville
2004-08-17 17:45     ` David S. Miller
2004-08-17 18:02   ` David S. Miller [this message]
2004-08-18  3:34     ` TG3 doesn't work in kernel 2.4.27 (Resolved!) Tetsuo Handa
2004-08-14 16:53 TG3 doesn't work in kernel 2.4.27 Tetsuo Handa
2004-08-15 19:57 ` Marcelo Tosatti
2004-08-15 21:59   ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040817110248.4c2f7cd8.davem@redhat.com \
    --to=davem@redhat.com \
    --cc=a5497108@anet.ne.jp \
    --cc=dev_null@anet.ne.jp \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.tosatti@cyclades.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox