From: Ingo Molnar <mingo@elte.hu>
To: Jens Maurer <Jens.Maurer@gmx.net>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
Arjan van de Ven <arjanv@redhat.com>
Subject: Re: [PATCH] Use x86 SSE instructions for clear_page, copy_page
Date: Wed, 18 Aug 2004 09:00:13 +0200 [thread overview]
Message-ID: <20040818070013.GA11048@elte.hu> (raw)
In-Reply-To: <4121A211.8080902@gmx.net>
* Jens Maurer <Jens.Maurer@gmx.net> wrote:
> The attached patch (against kernel 2.6.8.1) enables using SSE
> instructions for copy_page and clear_page.
besides the cache arguments Arjan raised, you are also corrupting SSE
registers big way. You are saving/clearing/restoring the TS but that's
not enough - what if e.g. a pagefault happened while userspace code
executed SSE code? You are corrupting those registers.
check out raid6_before_sse()/raid6_after_sse() how to write proper SSE
code for the kernel.
Ingo
next prev parent reply other threads:[~2004-08-18 6:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-17 6:13 [PATCH] Use x86 SSE instructions for clear_page, copy_page Jens Maurer
2004-08-17 7:27 ` Arjan van de Ven
2004-08-17 8:10 ` Andrey Panin
2004-08-17 8:11 ` Arjan van de Ven
2004-08-17 22:40 ` Jens Maurer
2004-08-18 2:33 ` David S. Miller
2004-08-22 20:49 ` Jens Maurer
2004-08-18 7:00 ` Ingo Molnar [this message]
2004-08-18 7:11 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040818070013.GA11048@elte.hu \
--to=mingo@elte.hu \
--cc=Jens.Maurer@gmx.net \
--cc=akpm@osdl.org \
--cc=arjanv@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox