From: Christoph Hellwig <hch@infradead.org>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: "Dave Jones" <davej@redhat.com>,
"Christoph Hellwig" <hch@infradead.org>,
"David Härdeman" <david@2gen.com>,
"lkml - Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: Oops modprobing i830 with 2.6.8.1
Date: Wed, 18 Aug 2004 10:15:40 +0100 [thread overview]
Message-ID: <20040818101540.A30983@infradead.org> (raw)
In-Reply-To: <1092801681.27352.194.camel@bach>; from rusty@rustcorp.com.au on Wed, Aug 18, 2004 at 02:01:21PM +1000
On Wed, Aug 18, 2004 at 02:01:21PM +1000, Rusty Russell wrote:
> Thx for reminder. Polished up the drm stuff: this compiles. Of course,
> as Christoph would say, it's still shit. However, the turd is now more
> polished.
>
> Dave, please consider removing the piggybacking of DRM module stubs; it
> is the cause of this horror. I don't know enough to know what that
> would break.
Actually this is is a classic example of over-engineering (not on your side
but the original drm side). IF a normal driver supports pci and isa devices
it depends on PCI || ISA and has ifdefs or stubs for both.
Similarly drm should depend on AGP for those cards where there are only
AGP versions (most of them) and the driver where pci is also posisble (some
ati driver only IIRC) could compile with or withut but I'd be a compile-time
thing.
next prev parent reply other threads:[~2004-08-18 9:16 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-17 22:08 Oops modprobing i830 with 2.6.8.1 David Härdeman
2004-08-17 23:37 ` Dave Jones
2004-08-17 23:43 ` Christoph Hellwig
2004-08-17 23:45 ` Dave Jones
2004-08-18 4:01 ` Rusty Russell
2004-08-18 9:15 ` Christoph Hellwig [this message]
2004-08-18 17:22 ` Alan Cox
2004-08-18 18:28 ` Christoph Hellwig
2004-08-18 17:37 ` Alan Cox
2004-08-18 18:45 ` Christoph Hellwig
2004-08-18 18:09 ` David Härdeman
-- strict thread matches above, loose matches on Subject: below --
2004-08-24 10:11 Dave Airlie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040818101540.A30983@infradead.org \
--to=hch@infradead.org \
--cc=davej@redhat.com \
--cc=david@2gen.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox