From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Rainer Weikusat <rainer.weikusat@sncag.com>
Cc: "bradgoodman.com" <bkgoodman@bradgoodman.com>,
alan@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] 2.4.27 - MTD cfi_cmdset_0002.c - Duplicate cleanup in error path
Date: Thu, 19 Aug 2004 12:54:05 -0300 [thread overview]
Message-ID: <20040819155405.GC4396@logos.cnet> (raw)
In-Reply-To: <87k6wtlvwk.fsf@farside.sncag.com>
Applied Rainer's patch, its equivalent and I his
"consisteny with other algorithms" point is a good one.
Thanks guys!
On Sat, Jul 24, 2004 at 03:14:03PM +0800, Rainer Weikusat wrote:
> "bradgoodman.com" <bkgoodman@bradgoodman.com> writes:
> > Patch to 2.4.x: Corrects an obvious error where all of the cleanups are done
> > twice in the event of a chip programming error. This can result in
> > kernel BUG() getting called on subsequent programming attempts.
<snip>
> That way, it is consistent with the other low-level chip access
> functions. But the algorithm is per se buggy, anyway, because except
> if DQ5 was raised before, the chip is not 'ready' (for reading array
> data), but still in programming mode and will remain there until the
> 'embedded programming algorithm' stops, because (according to the
> docs) a reset command will not be accepted until DQ5 has been raised
> and the opportunityto check for that is gone after the syscall
> returned to the caller.
next prev parent reply other threads:[~2004-08-19 19:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-23 19:47 [PATCH] 2.4.27 - MTD cfi_cmdset_0002.c - Duplicate cleanup in error path bradgoodman.com
2004-07-24 7:14 ` Rainer Weikusat
2004-08-19 15:54 ` Marcelo Tosatti [this message]
2004-08-19 20:18 ` bkgoodman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040819155405.GC4396@logos.cnet \
--to=marcelo.tosatti@cyclades.com \
--cc=alan@redhat.com \
--cc=bkgoodman@bradgoodman.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rainer.weikusat@sncag.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox