From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: akpm@osdl.org
Cc: linux-kernel@vger.kernel.org
Subject: filemap_fdatawait() wait_on_page_writeback_range(mapping, 0, -1)?
Date: Thu, 19 Aug 2004 17:17:29 -0300 [thread overview]
Message-ID: <20040819201729.GC5278@logos.cnet> (raw)
Hi Andrew,
I dont understand why we do call wait_on_page_writeback_range() with -1
as the "end" argument.
Is there a good reason for that? I bet so...
-1 sounds pretty stupid at first, it does unnecessary calls to
the radix lookup code.
--- a/mm/filemap.c.orig 2004-08-19 14:36:02.000000000 -0300
+++ b/mm/filemap.c.isize 2004-08-19 18:17:14.000000000 -0300
@@ -231,7 +231,7 @@
*/
int filemap_fdatawait(struct address_space *mapping)
- return wait_on_page_writeback_range(mapping, 0, -1);
+ return wait_on_page_writeback_range(mapping, 0, i_size_read(mapping->host));
}
EXPORT_SYMBOL(filemap_fdatawait);
next reply other threads:[~2004-08-19 21:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-19 20:17 Marcelo Tosatti [this message]
2004-08-19 21:49 ` filemap_fdatawait() wait_on_page_writeback_range(mapping, 0, -1)? Andrew Morton
2004-08-19 22:13 ` Marcelo Tosatti
2004-08-19 23:33 ` Andrew Morton
[not found] ` <1092990808.20987.8.camel@imp.csi.cam.ac.uk>
2004-08-20 8:36 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040819201729.GC5278@logos.cnet \
--to=marcelo.tosatti@cyclades.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox