public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: John Levon <levon@movementarian.org>
To: Andrew Morton <akpm@osdl.org>
Cc: oprofile-list@lists.sourceforge.net,
	linux-kernel@vger.kernel.org, jbarnes@sgi.com, anton@samba.org,
	phil.el@wanadoo.fr
Subject: Re: [PATCH] improve OProfile on many-way systems
Date: Sun, 22 Aug 2004 00:55:56 +0100	[thread overview]
Message-ID: <20040821235556.GA22619@compsoc.man.ac.uk> (raw)
In-Reply-To: <20040821163628.10cfa049.akpm@osdl.org>

On Sat, Aug 21, 2004 at 04:36:28PM -0700, Andrew Morton wrote:

> Well yes, but it's not magic.

Absolutely. But since the vast majority of the bugs in oprofile kernel
code are either identified or reported by kernel developers, it's really
that audience that need to do testing beyond what I'm outfitted for.

For example a while ago wli walked right into an obvious bug on one of
his machines that hadn't shown up during /any/ of my testing since the
code was merged.

> One of my mental checkpoints before sending a patch to Linus is "has this
> been sufficiently tested".  I don't know how to answer that in this case.

Me neither. It would certainly be great to have a decent regression test
suite for OProfile, but I don't have one other than the usual by-hand
testing I do. Isn't there some STP thing or something at OSDL we can
get people to try?

> In fact I don't know how to answer that in a _lot_ of cases, but if I know
> that people are using the feature in anger and we're sufficiently early in
> the 2.6.x cycle then I'll assume that regressions will be picked up.

I must admit I'm still not clear on when the equivalent of "early in the
2.6.x cycle" is going to happen again... I have no idea when, if ever,
call-graph OProfile would be suitable to merge.

> Anyway.  My question was mainly a prod in the antonward direction ;)

That'd be handy certainly...

regards
john

  reply	other threads:[~2004-08-21 23:56 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-21 19:26 [PATCH] improve OProfile on many-way systems John Levon
2004-08-21 20:58 ` Andrew Morton
2004-08-21 22:06   ` Jesse Barnes
2004-08-21 23:14     ` John Levon
2004-08-22  4:34       ` Anton Blanchard
2004-08-24  0:07         ` John Levon
2004-08-21 23:22   ` John Levon
2004-08-21 23:36     ` Andrew Morton
2004-08-21 23:55       ` John Levon [this message]
2004-08-22  4:41         ` Andrew Morton
2004-08-22 22:42           ` John Levon
2004-08-22  3:50       ` Anton Blanchard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040821235556.GA22619@compsoc.man.ac.uk \
    --to=levon@movementarian.org \
    --cc=akpm@osdl.org \
    --cc=anton@samba.org \
    --cc=jbarnes@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oprofile-list@lists.sourceforge.net \
    --cc=phil.el@wanadoo.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox