From: Dave C Boutcher <sleddog@us.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: Christoph Hellwig <hch@infradead.org>,
paulus@samba.org, akpm@osdl.org, ipseries-list@redhat.com
Subject: Re: [PATCH] ppc64 mf_proc file position fix
Date: Mon, 23 Aug 2004 13:18:58 -0500 [thread overview]
Message-ID: <20040823181858.GA15598@cs.umn.edu> (raw)
In-Reply-To: <20040823185423.A19476@infradead.org>
On Mon, Aug 23, 2004 at 06:54:23PM +0100, Christoph Hellwig wrote:
> On Fri, Aug 20, 2004 at 03:10:32PM -0500, Dave C Boutcher wrote:
> > Andrew,
> >
> > arch/ppc64/kernel/mf_proc.c uses a bad interface for moving
> > along file position in a proc_write routine. This quit working
> > altogether in 2.6.8. Patch to fix. And I did a quick scan of the
> > kernel to see if anyone else was similarly broken...apparantly not :-)
> >
> > Fixes a broken update of f_pos in a proc file write routine.
>
> What about moving on to seq_file while you're at it? Switching from
> one deprecated interface to another doesn't really sound like a worthwile
> effort.
The specific problem was on the write side, not the read side, so AFAIK,
seq_file wasn't going to help out. I started re-writing the whole file
to use seq_file for all the read stuff, and after a few hours into it I
decided to just fix the broken bit rather than gratuitously rewriting
the whole thing.
--
Dave Boutcher
prev parent reply other threads:[~2004-08-23 18:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-20 20:10 [PATCH] ppc64 mf_proc file position fix Dave C Boutcher
2004-08-23 17:54 ` Christoph Hellwig
2004-08-23 18:18 ` Dave C Boutcher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040823181858.GA15598@cs.umn.edu \
--to=sleddog@us.ibm.com \
--cc=akpm@osdl.org \
--cc=boutcher@cs.umn.edu \
--cc=hch@infradead.org \
--cc=ipseries-list@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox