From: Andrew Morton <akpm@osdl.org>
To: Dave Jones <davej@redhat.com>
Cc: linux-kernel@vger.kernel.org, suparna@in.ibm.com
Subject: Re: [PATCH] Writeback page range hint
Date: Mon, 23 Aug 2004 18:21:09 -0700 [thread overview]
Message-ID: <20040823182109.6af19081.akpm@osdl.org> (raw)
In-Reply-To: <20040824011822.GB15668@redhat.com>
Dave Jones <davej@redhat.com> wrote:
>
> On Mon, Aug 23, 2004 at 06:14:00PM -0700, Andrew Morton wrote:
>
> > > > + int nonblocking:1; /* Don't get stuck on request queues */
> > > > + int encountered_congestion:1; /* An output: a queue is full */
> > > > + int for_kupdate:1; /* A kupdate writeback */
> > > > + int for_reclaim:1; /* Invoked from the page allocator */
> > >
> > > Causes sparse spew..
> > >
> > > include/linux/writeback.h:54:19: warning: dubious one-bit signed bitfield
> > > include/linux/writeback.h:55:30: warning: dubious one-bit signed bitfield
> > > include/linux/writeback.h:56:19: warning: dubious one-bit signed bitfield
> > > include/linux/writeback.h:57:19: warning: dubious one-bit signed bitfield
> >
> > That's fussy of it. I assume this shuts it up?
>
> very likely (its 2am, and I'm feeling too lazy to check).
That's the middle of the working day.
> though, is there any real reason why they are bitfields at all ?
That should have been in the changelog. Bad Suparna.
These structures are allocated on the stack in the (deep) writeback paths.
Saving a few bytes there does seem to be worth the increased code size.
next prev parent reply other threads:[~2004-08-24 1:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200408232138.i7NLcfJd019125@hera.kernel.org>
2004-08-24 1:07 ` [PATCH] Writeback page range hint Dave Jones
2004-08-24 1:14 ` Andrew Morton
2004-08-24 1:18 ` Dave Jones
2004-08-24 1:21 ` Andrew Morton [this message]
2004-08-24 1:29 ` wli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040823182109.6af19081.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=suparna@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox