From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266116AbUHWUGl (ORCPT ); Mon, 23 Aug 2004 16:06:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266069AbUHWUEo (ORCPT ); Mon, 23 Aug 2004 16:04:44 -0400 Received: from imladris.demon.co.uk ([193.237.130.41]:33800 "EHLO phoenix.infradead.org") by vger.kernel.org with ESMTP id S266670AbUHWSts (ORCPT ); Mon, 23 Aug 2004 14:49:48 -0400 Date: Mon, 23 Aug 2004 19:49:36 +0100 From: Christoph Hellwig To: James Morris Cc: Andrew Morton , viro@parcelfarce.linux.theplanet.co.uk, Stephen Smalley , linux-kernel@vger.kernel.org Subject: Re: [PATCH][1/7] xattr consolidation - libfs Message-ID: <20040823194936.A20008@infradead.org> Mail-Followup-To: Christoph Hellwig , James Morris , Andrew Morton , viro@parcelfarce.linux.theplanet.co.uk, Stephen Smalley , linux-kernel@vger.kernel.org References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: ; from jmorris@redhat.com on Mon, Aug 23, 2004 at 02:15:15PM -0400 X-SRS-Rewrite: SMTP reverse-path rewritten from by phoenix.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 23, 2004 at 02:15:15PM -0400, James Morris wrote: > This patch consolidates common xattr handling logic into libfs, for > use by ext2, ext3 and devpts, as well as upcoming ramfs and tmpfs xattr code. Please don't do it this way. By making the xattr handlers constant for a superblock's lifetime you can get rid of all the locking, and the arbitrary limit on the number of xattrs. Please also move the code to xattr.c where it belong (long-term I'd like to kill the old inode ops so we can do things like moving the permission checks for user xattrs into common code where they belong) Also s/simple_// for most symbols as this stuff isn't simple, in fact it's quite complex :)