From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266378AbUHWUMU (ORCPT ); Mon, 23 Aug 2004 16:12:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266509AbUHWUKc (ORCPT ); Mon, 23 Aug 2004 16:10:32 -0400 Received: from imladris.demon.co.uk ([193.237.130.41]:35080 "EHLO phoenix.infradead.org") by vger.kernel.org with ESMTP id S267386AbUHWTEG (ORCPT ); Mon, 23 Aug 2004 15:04:06 -0400 Date: Mon, 23 Aug 2004 20:03:53 +0100 From: Christoph Hellwig To: James Morris Cc: Andrew Morton , viro@parcelfarce.linux.theplanet.co.uk, Stephen Smalley , linux-kernel@vger.kernel.org, Chris Wright Subject: Re: [PATCH][2/7] xattr consolidation - LSM hook changes Message-ID: <20040823200353.A20114@infradead.org> Mail-Followup-To: Christoph Hellwig , James Morris , Andrew Morton , viro@parcelfarce.linux.theplanet.co.uk, Stephen Smalley , linux-kernel@vger.kernel.org, Chris Wright References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5.1i In-Reply-To: ; from jmorris@redhat.com on Mon, Aug 23, 2004 at 02:16:17PM -0400 X-SRS-Rewrite: SMTP reverse-path rewritten from by phoenix.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 23, 2004 at 02:16:17PM -0400, James Morris wrote: > This patch replaces the dentry parameter with an inode in the LSM > inode_{set|get|list}security hooks, in keeping with the ext2/ext3 code. > dentries are not needed here. Given that the actual methods take a dentry this sounds like a bad design. Can;t you just pass down the dentry through all of the ext2 interfaces? (And again, mid-term these checks should move to the VFS)