From: John Levon <levon@movementarian.org>
To: Anton Blanchard <anton@samba.org>
Cc: Jesse Barnes <jbarnes@sgi.com>, Andrew Morton <akpm@osdl.org>,
oprofile-list@lists.sourceforge.net,
linux-kernel@vger.kernel.org, phil.el@wanadoo.fr
Subject: Re: [PATCH] improve OProfile on many-way systems
Date: Tue, 24 Aug 2004 01:07:07 +0100 [thread overview]
Message-ID: <20040824000707.GA59224@compsoc.man.ac.uk> (raw)
In-Reply-To: <20040822043359.GB8702@krispykreme>
On Sun, Aug 22, 2004 at 02:34:00PM +1000, Anton Blanchard wrote:
> > That must be profile_rwsem in kernel/profile.c since the rest of the
> > code won't be doing anything. I imagine it needs RCUing.
>
> Also profile_hook is called in the interrupt handler and has a global
> spinlock (profile_lock). If the notifier hooks used RCU then we wouldnt
> need this lock.
If that were the problem he'd see it with profile=2 though, since it
uses the same mechanism... should still be fixed of course.
john
next prev parent reply other threads:[~2004-08-24 0:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-21 19:26 [PATCH] improve OProfile on many-way systems John Levon
2004-08-21 20:58 ` Andrew Morton
2004-08-21 22:06 ` Jesse Barnes
2004-08-21 23:14 ` John Levon
2004-08-22 4:34 ` Anton Blanchard
2004-08-24 0:07 ` John Levon [this message]
2004-08-21 23:22 ` John Levon
2004-08-21 23:36 ` Andrew Morton
2004-08-21 23:55 ` John Levon
2004-08-22 4:41 ` Andrew Morton
2004-08-22 22:42 ` John Levon
2004-08-22 3:50 ` Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040824000707.GA59224@compsoc.man.ac.uk \
--to=levon@movementarian.org \
--cc=akpm@osdl.org \
--cc=anton@samba.org \
--cc=jbarnes@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oprofile-list@lists.sourceforge.net \
--cc=phil.el@wanadoo.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox