From: wli@holomorphy.com
To: Dave Jones <davej@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
suparna@in.ibm.com
Subject: Re: [PATCH] Writeback page range hint
Date: Mon, 23 Aug 2004 18:29:24 -0700 [thread overview]
Message-ID: <20040824012924.GP4418@holomorphy.com> (raw)
In-Reply-To: <20040824010723.GA15668@redhat.com>
On Tue, Aug 24, 2004 at 02:07:23AM +0100, Dave Jones wrote:
> Causes sparse spew..
> include/linux/writeback.h:54:19: warning: dubious one-bit signed bitfield
> include/linux/writeback.h:55:30: warning: dubious one-bit signed bitfield
> include/linux/writeback.h:56:19: warning: dubious one-bit signed bitfield
> include/linux/writeback.h:57:19: warning: dubious one-bit signed bitfield
Does this help?
Index: mm4-2.6.8.1/include/linux/writeback.h
===================================================================
--- mm4-2.6.8.1.orig/include/linux/writeback.h 2004-08-23 16:11:10.318739856 -0700
+++ mm4-2.6.8.1/include/linux/writeback.h 2004-08-23 18:26:45.790960088 -0700
@@ -51,10 +51,10 @@
loff_t start;
loff_t end;
- int nonblocking:1; /* Don't get stuck on request queues */
- int encountered_congestion:1; /* An output: a queue is full */
- int for_kupdate:1; /* A kupdate writeback */
- int for_reclaim:1; /* Invoked from the page allocator */
+ unsigned nonblocking:1, /* Don't get stuck on request queues */
+ encountered_congestion:1, /* An output: a queue is full */
+ for_kupdate:1, /* A kupdate writeback */
+ for_reclaim:1; /* Invoked from the page allocator */
};
/*
prev parent reply other threads:[~2004-08-24 1:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200408232138.i7NLcfJd019125@hera.kernel.org>
2004-08-24 1:07 ` [PATCH] Writeback page range hint Dave Jones
2004-08-24 1:14 ` Andrew Morton
2004-08-24 1:18 ` Dave Jones
2004-08-24 1:21 ` Andrew Morton
2004-08-24 1:29 ` wli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040824012924.GP4418@holomorphy.com \
--to=wli@holomorphy.com \
--cc=akpm@osdl.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=suparna@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox