public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ray Lehtiniemi <rayl@mail.com>
To: linux-kernel@vger.kernel.org
Subject: nfsroot compile broken in 2.6.9-rc1?
Date: Tue, 24 Aug 2004 10:50:02 -0600	[thread overview]
Message-ID: <20040824165002.GA4314@mail.com> (raw)


hi folks

just pulled the latest changes, and it seems nfsroot no longer
compiles:

     CC      fs/nfs/nfsroot.o
   fs/nfs/nfsroot.c: In function `root_nfs_get_handle':
   fs/nfs/nfsroot.c:499: error: cannot convert to a pointer type
   fs/nfs/nfsroot.c:499: error: cannot convert to a pointer type
   make[2]: *** [fs/nfs/nfsroot.o] Error 1


i'm no bitkeeper expert yet, but it seems that this change:

   ChangeSet 1.1803.109.17 2004/08/23 18:16:26 trond.myklebust@fys.uio.no

may not be complete...

this patch compiles and boots for me...

===== fs/nfs/nfsroot.c 1.20 vs edited =====
--- 1.20/fs/nfs/nfsroot.c	2004-06-08 15:47:11 -06:00
+++ edited/fs/nfs/nfsroot.c	2004-08-24 10:26:29 -06:00
@@ -496,7 +496,7 @@
 		printk(KERN_ERR "Root-NFS: Server returned error %d "
 				"while mounting %s\n", status, nfs_path);
 	else
-		nfs_copy_fh(nfs_data.root, fh);
+		nfs_copy_fh((struct nfs_fh *)&nfs_data.root, (struct nfs_fh *)&fh);
 
 	return status;
 }



please cc me on replies, as i'm not subscribed.

thanks

-- 
----------------------------------------------------------------------
     Ray L   <rayl@mail.com>

             reply	other threads:[~2004-08-24 16:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-24 16:50 Ray Lehtiniemi [this message]
2004-08-24 17:27 ` nfsroot compile broken in 2.6.9-rc1? Trond Myklebust
  -- strict thread matches above, loose matches on Subject: below --
2004-08-25 13:08 Lever, Charles

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040824165002.GA4314@mail.com \
    --to=rayl@mail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox