public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: William Lee Irwin III <wli@holomorphy.com>
To: Albert Cahalan <albert@users.sf.net>
Cc: linux-kernel mailing list <linux-kernel@vger.kernel.org>
Subject: Re: fix text reporting in O(1) proc_pid_statm()
Date: Tue, 24 Aug 2004 16:18:41 -0700	[thread overview]
Message-ID: <20040824231841.GH2793@holomorphy.com> (raw)
In-Reply-To: <20040824231236.GG2793@holomorphy.com>

On Tue, Aug 24, 2004 at 07:06:56PM -0400, Albert Cahalan wrote:
>> Back in the days of a.out, statm also contained lrs
>> for libraries. ELF broke this.
>> The statm VM size is supposed to count IO mappings.
>> So if your X server maps 64 MB of video RAM, then
>> the statm file should have a value 64 MB larger than
>> the status file has.

On Tue, Aug 24, 2004 at 04:12:36PM -0700, William Lee Irwin III wrote:
> This would not be difficult to perform additional accounting for.
> I'll follow up with that shortly.

Account reserved memory properly as per acahalan's sepecified semantics.


Index: mm4-2.6.8.1/fs/proc/task_mmu.c
===================================================================
--- mm4-2.6.8.1.orig/fs/proc/task_mmu.c	2004-08-24 10:00:21.530755896 -0700
+++ mm4-2.6.8.1/fs/proc/task_mmu.c	2004-08-24 16:14:48.802211472 -0700
@@ -19,7 +19,7 @@
 		"VmStk:\t%8lu kB\n"
 		"VmExe:\t%8lu kB\n"
 		"VmLib:\t%8lu kB\n",
-		mm->total_vm << (PAGE_SHIFT-10),
+		(mm->total_vm - mm->reserved_vm) << (PAGE_SHIFT-10),
 		mm->locked_vm << (PAGE_SHIFT-10),
 		mm->rss << (PAGE_SHIFT-10),
 		data << (PAGE_SHIFT-10),
Index: mm4-2.6.8.1/include/linux/sched.h
===================================================================
--- mm4-2.6.8.1.orig/include/linux/sched.h	2004-08-23 18:29:33.000000000 -0700
+++ mm4-2.6.8.1/include/linux/sched.h	2004-08-24 16:11:15.251676088 -0700
@@ -226,7 +226,7 @@
 	unsigned long start_brk, brk, start_stack;
 	unsigned long arg_start, arg_end, env_start, env_end;
 	unsigned long rlimit_rss, rss, total_vm, locked_vm, shared_vm;
-	unsigned long exec_vm, stack_vm, def_flags;
+	unsigned long exec_vm, stack_vm, reserved_vm, def_flags;
 
 	unsigned long saved_auxv[40]; /* for /proc/PID/auxv */
 
Index: mm4-2.6.8.1/mm/mmap.c
===================================================================
--- mm4-2.6.8.1.orig/mm/mmap.c	2004-08-23 23:33:42.000000000 -0700
+++ mm4-2.6.8.1/mm/mmap.c	2004-08-24 16:13:14.139602376 -0700
@@ -749,6 +749,8 @@
 		mm->stack_vm += pages;
 	if (flags & VM_EXEC)
 		mm->exec_vm += pages;
+	if (flags & (VM_RESERVED|VM_IO))
+		mm->reserved_vm += pages;
 }
 
 /*

  reply	other threads:[~2004-08-24 23:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-24 23:06 fix text reporting in O(1) proc_pid_statm() Albert Cahalan
2004-08-24 23:12 ` William Lee Irwin III
2004-08-24 23:18   ` William Lee Irwin III [this message]
2004-08-24 23:24     ` William Lee Irwin III
2004-08-25  0:01       ` William Lee Irwin III
2004-08-25  2:52   ` Albert Cahalan
2004-08-25  3:04     ` William Lee Irwin III
  -- strict thread matches above, loose matches on Subject: below --
2004-08-22  8:34 2.6.8.1-mm4 Andrew Morton
2004-08-23 20:21 ` 2.6.8.1-mm4 wli
2004-08-24  6:14   ` 2.6.8.1-mm4 Andrew Morton
2004-08-24  7:55     ` O(1) proc_pid_statm() William Lee Irwin III
2004-08-24 17:05       ` fix text reporting in " William Lee Irwin III

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040824231841.GH2793@holomorphy.com \
    --to=wli@holomorphy.com \
    --cc=albert@users.sf.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox