Re: [PATCH] add PCI ROMs to sysfs

[Matthew Wilcox <willy@debian.org>]

On Wed, Aug 25, 2004 at 11:06:06AM -0700, Jon Smirl wrote:
> Final version, I hope, includes short decription and Signed-off-by at
> top of patch.

+/**
+ * pci_remove_rom - disable the ROM and remove it's sysfs attribute
+ * @dev: pointer to pci device struct
+ * 
+ */

It's its, not it's, unless of course you mean it is, in which case it's
it's not its.

More helpfully, "its" is a pronoun like "his" or "hers".  "it's" is an
abbreviation for "it is".

Also, this is a mistake:

+/**
+ * pci_remove_rom - disable the ROM and remove it's sysfs attribute
+ * @dev: pointer to pci device struct
+ *
+ */
+void 
+pci_cleanup_rom(struct pci_dev *pdev) 

I'd like a little bit of description about the difference between
pci_cleanup_rom and pci_remove_rom in the docbook, please.

-- 
"Next the statesmen will invent cheap lies, putting the blame upon 
the nation that is attacked, and every man will be glad of those
conscience-soothing falsities, and will diligently study them, and refuse
to examine any refutations of them; and thus he will by and by convince 
himself that the war is just, and will thank God for the better sleep 
he enjoys after this process of grotesque self-deception." -- Mark Twain