From: Adrian Bunk <bunk@fs.tum.de>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Cc: linux-kernel@vger.kernel.org, jgarzik@pobox.com,
linux-net@vger.kernel.org
Subject: [2.4 patch][1/6] lmc_media.c: fix gcc 3.4 compilation
Date: Thu, 26 Aug 2004 21:56:43 +0200 [thread overview]
Message-ID: <20040826195643.GD12772@fs.tum.de> (raw)
In-Reply-To: <20040826195133.GB12772@fs.tum.de>
I got the following compile error when trying to build 2.4.28-pre2 using
gcc 3.4:
<-- snip -->
...
gcc-3.4 -D__KERNEL__
-I/home/bunk/linux/kernel-2.4/linux-2.4.28-pre2-full/include -Wall
-Wstrict-prototypes -Wno-trigraphs -O2 -fno-strict-aliasing -fno-common
-fomit-frame-pointer -pipe -mpreferred-stack-boundary=2 -march=athlon
-fno-unit-at-a-time -I. -nostdinc -iwithprefix include
-DKBUILD_BASENAME=lmc_media -c -o lmc_media.o lmc_media.c
lmc_media.c: In function `lmc_t1_get_link_status':
lmc_debug.h:50: sorry, unimplemented: inlining failed in call to
'lmc_trace': function body not available
lmc_media.c:1073: sorry, unimplemented: called from here
lmc_debug.h:50: sorry, unimplemented: inlining failed in call to
'lmc_trace': function body not available
lmc_media.c:1168: sorry, unimplemented: called from here
make[5]: *** [lmc_media.o] Error 1
make[5]: Leaving directory `/home/bunk/linux/kernel-2.4/linux-2.4.28-pre2-full/drivers/net/wan/lmc'
<-- snip -->
The patch below fixes this issue by uninlining lmc_trace.
Signed-off-by: Adrian Bunk <bunk@fs.tum.de>
--- linux-2.4.28-pre2-full/drivers/net/wan/lmc/lmc_debug.h.old 2004-08-26 18:58:03.000000000 +0200
+++ linux-2.4.28-pre2-full/drivers/net/wan/lmc/lmc_debug.h 2004-08-26 18:58:32.000000000 +0200
@@ -47,6 +47,6 @@
void lmcConsoleLog(char *type, unsigned char *ucData, int iLen);
void lmcEventLog (u_int32_t EventNum, u_int32_t arg2, u_int32_t arg3);
-inline void lmc_trace(struct net_device *dev, char *msg);
+void lmc_trace(struct net_device *dev, char *msg);
#endif
--- linux-2.4.28-pre2-full/drivers/net/wan/lmc/lmc_debug.c.old 2004-08-26 18:59:32.000000000 +0200
+++ linux-2.4.28-pre2-full/drivers/net/wan/lmc/lmc_debug.c 2004-08-26 18:59:47.000000000 +0200
@@ -66,7 +66,7 @@
#endif
}
-inline void lmc_trace(struct net_device *dev, char *msg){
+void lmc_trace(struct net_device *dev, char *msg){
#ifdef LMC_TRACE
unsigned long j = jiffies + 3; /* Wait for 50 ms */
next prev parent reply other threads:[~2004-08-26 20:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-26 19:51 [2.4 patch][0/6] fix compile errors with gcc 3.4 Adrian Bunk
2004-08-26 19:54 ` [2.4 patch][1/6] ibmphp_res.c: fix gcc 3.4 compilation Adrian Bunk
2004-08-27 12:03 ` Marcelo Tosatti
2004-08-27 14:54 ` Adrian Bunk
2004-08-26 19:56 ` Adrian Bunk [this message]
2004-08-28 22:58 ` [2.4 patch][1/6] lmc_media.c: " Jeff Garzik
2004-08-28 23:13 ` Adrian Bunk
2004-08-26 19:59 ` [2.4 patch][3/6] ircomm_param.c: fix __FUNCTION__ paste error Adrian Bunk
2004-08-26 20:02 ` [2.4 patch][4/6] irlmp.c: fix gcc 3.4 compilation Adrian Bunk
2004-08-26 20:04 ` [2.4 patch][5/6] asm-i386/smpboot.h: " Adrian Bunk
2004-08-26 20:07 ` [2.4 patch][6/6] dscc4.c: " Adrian Bunk
2004-08-27 18:52 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040826195643.GD12772@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox