From: Folke Ashberg <folke@ashberg.de>
To: linux-kernel@vger.kernel.org
Subject: hpt366.c: wrong timings used since 2.6.8
Date: Fri, 27 Aug 2004 00:36:19 +0200 [thread overview]
Message-ID: <20040826223617.GA4557@ashberg.de> (raw)
Hi there,
i have an HPT372A (rev 02) (PCI_DEVICE_ID_TTI_HPT372) and since 2.6.8
i've got an Ooooops.
I saw that hpt366.c got support for HPT372_N_ and its special timings, but
that timings have been used for my HPT372_A_ and caused the Oops.
I did the following and now it works:
-------------------------------------------
diff -pur linux-2.6.9rc1-orig/drivers/ide/pci/hpt366.c linux-2.6.9rc1/drivers/ide/pci/hpt366.c
--- linux-2.6.9rc1-orig/drivers/ide/pci/hpt366.c 2004-08-26 19:42:16.000000000 +0200
+++ linux-2.6.9rc1/drivers/ide/pci/hpt366.c 2004-08-26 23:22:56.000000000 +0200
@@ -881,7 +881,7 @@ static int __devinit init_hpt37x(struct
/* interrupt force enable */
pci_write_config_byte(dev, 0x5a, (reg5ah & ~0x10));
- if(dmabase)
+ if(dev->device == PCI_DEVICE_ID_TTI_HPT372N && dmabase)
{
did = inb(dmabase + 0x22);
rid = inb(dmabase + 0x28);
@@ -1132,7 +1132,7 @@ static void __devinit init_hwif_hpt366(i
unsigned long dmabase = hwif->dma_base;
int is_372n = 0;
- if(dmabase)
+ if(dev->device == PCI_DEVICE_ID_TTI_HPT372N && dmabase)
{
did = inb(dmabase + 0x22);
rid = inb(dmabase + 0x28);
-------------------------------------------
Not to also check dev->device for the N-Version at that two places
(which are used also for other versions) seems to be wrong.
Kind Regards
Folke Ashberg
--
Folke Ashberg
folke@ashberg.de
www.ashberg.de
next reply other threads:[~2004-08-26 22:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-26 22:36 Folke Ashberg [this message]
2004-08-29 13:18 ` hpt366.c: wrong timings used since 2.6.8 Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040826223617.GA4557@ashberg.de \
--to=folke@ashberg.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox