From: Adrian Bunk <bunk@fs.tum.de>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Cc: linux-kernel@vger.kernel.org, gregkh@us.ibm.com
Subject: Re: [2.4 patch][1/6] ibmphp_res.c: fix gcc 3.4 compilation
Date: Fri, 27 Aug 2004 16:54:16 +0200 [thread overview]
Message-ID: <20040827145416.GP12772@fs.tum.de> (raw)
In-Reply-To: <20040827120330.GD32707@logos.cnet>
On Fri, Aug 27, 2004 at 09:03:31AM -0300, Marcelo Tosatti wrote:
> >
> > The patch below fixes this issue by uninlining find_bus_wprev (as done
> > in 2.6).
>
> Just out of curiosity, if you move the inlined function up to the beginning of the
> file (before any calls to it), and remove the declaration (at 45), does it
> stop complaining?
Yes it does.
For all these inline errors you can choose between uninlining and
reordering the file.
In this case I did choose unlinlining because find_bus_wprev is
uninlined in 2.6 .
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2004-08-27 14:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-26 19:51 [2.4 patch][0/6] fix compile errors with gcc 3.4 Adrian Bunk
2004-08-26 19:54 ` [2.4 patch][1/6] ibmphp_res.c: fix gcc 3.4 compilation Adrian Bunk
2004-08-27 12:03 ` Marcelo Tosatti
2004-08-27 14:54 ` Adrian Bunk [this message]
2004-08-26 19:56 ` [2.4 patch][1/6] lmc_media.c: " Adrian Bunk
2004-08-28 22:58 ` Jeff Garzik
2004-08-28 23:13 ` Adrian Bunk
2004-08-26 19:59 ` [2.4 patch][3/6] ircomm_param.c: fix __FUNCTION__ paste error Adrian Bunk
2004-08-26 20:02 ` [2.4 patch][4/6] irlmp.c: fix gcc 3.4 compilation Adrian Bunk
2004-08-26 20:04 ` [2.4 patch][5/6] asm-i386/smpboot.h: " Adrian Bunk
2004-08-26 20:07 ` [2.4 patch][6/6] dscc4.c: " Adrian Bunk
2004-08-27 18:52 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040827145416.GP12772@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=gregkh@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox