2.6.19-rc1 stv0299 fix

2.6.19-rc1 stv0299 fix

[Jacek Popławski]

Hi!

I use SkyStar 2.6c DVB card. I noticed that I can't watch digital television
anymore, after 2.6.7 to 2.6.9-rc1 upgrade. First reason was change of DVB
device, but second one is little bug in kernel.

Name of device has been changed in 2.6.9-rc1 to "SkyStar2", but module stv0299
still compares name with "Technisat SkyStar2 driver", strings are different,
and result is that stv0299 detects invalid tuner type. Not only I am not able
to tune anything, but also I can crash system just by reloading DVB modules and
being in X at same time.

Following obvious patch fixes problem.

--- linux-2.6.9-rc1/drivers/media/dvb/frontends/stv0299.c	2004-08-25 21:40:56.000000000 +0200
+++ linux/drivers/media/dvb/frontends/stv0299.c	2004-08-30 02:08:00.902739808 +0200
@@ -1271,7 +1271,7 @@
 
 	printk ("%s: try to attach to %s\n", __FUNCTION__, adapter->name);
 
-	if ( strcmp(adapter->name, "Technisat SkyStar2 driver") == 0 )
+	if ( strcmp(adapter->name, "SkyStar2") == 0 )
 	{
 	    printk ("%s: setup for tuner Samsung TBMU24112IMB\n", __FILE__)


-- 
Free Software - find interesting programs and change them
NetHack - meet interesting creatures, kill them and eat their bodies
Usenet - meet interesting people from all over the world and flame them
Decopter - unrealistic helicopter simulator, get it from http://decopter.sf.net

Re: 2.6.19-rc1 stv0299 fix

[Johannes Stezenbach]

On Mon, Aug 30, 2004 at 07:52:44AM +0000, Jacek Pop?awski wrote:
> 
> I use SkyStar 2.6c DVB card. I noticed that I can't watch digital television
> anymore, after 2.6.7 to 2.6.9-rc1 upgrade. First reason was change of DVB
> device, but second one is little bug in kernel.
> 
> Name of device has been changed in 2.6.9-rc1 to "SkyStar2", but module stv0299
> still compares name with "Technisat SkyStar2 driver", strings are different,
> and result is that stv0299 detects invalid tuner type. Not only I am not able
> to tune anything, but also I can crash system just by reloading DVB modules and
> being in X at same time.

How so? What does the DVB driver have to do with X?

> Following obvious patch fixes problem.

Patch looks good. Please apply.

Johannes


--- linux-2.6.9-rc1/drivers/media/dvb/frontends/stv0299.c	2004-08-25 21:40:56.000000000 +0200
+++ linux/drivers/media/dvb/frontends/stv0299.c	2004-08-30 02:08:00.902739808 +0200
@@ -1271,7 +1271,7 @@
 
 	printk ("%s: try to attach to %s\n", __FUNCTION__, adapter->name);
 
-	if ( strcmp(adapter->name, "Technisat SkyStar2 driver") == 0 )
+	if ( strcmp(adapter->name, "SkyStar2") == 0 )
 	{
 	    printk ("%s: setup for tuner Samsung TBMU24112IMB\n", __FILE__)