From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S267356AbUH3IIS (ORCPT ); Mon, 30 Aug 2004 04:08:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S267382AbUH3IIR (ORCPT ); Mon, 30 Aug 2004 04:08:17 -0400 Received: from holomorphy.com ([207.189.100.168]:34995 "EHLO holomorphy.com") by vger.kernel.org with ESMTP id S267356AbUH3IIN (ORCPT ); Mon, 30 Aug 2004 04:08:13 -0400 Date: Mon, 30 Aug 2004 01:07:57 -0700 From: William Lee Irwin III To: andersen@codepoet.org Cc: "David S. Miller" , mmazur@kernel.pl, linux-kernel@vger.kernel.org Subject: Re: [ANNOUNCE] linux-libc-headers 2.6.8.1 Message-ID: <20040830080757.GD5492@holomorphy.com> Mail-Followup-To: William Lee Irwin III , andersen@codepoet.org, "David S. Miller" , mmazur@kernel.pl, linux-kernel@vger.kernel.org References: <200408292232.14446.mmazur@kernel.pl> <20040830062856.GA10475@codepoet.org> <20040830002422.4b634c6c.davem@davemloft.net> <20040830074835.GA12963@codepoet.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040830074835.GA12963@codepoet.org> Organization: The Domain of Holomorphy User-Agent: Mutt/1.5.6+20040722i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon Aug 30, 2004 at 12:24:22AM -0700, David S. Miller wrote: >> It has never been a constant, and any portable piece of >> software needs to evaluate it not at compile time. >> When I first did the sparc64 port, the biggest source of >> portability problems was of the "uses PAGE_SIZE in some way" >> nature. >> This is a positive change, we should break the build of these >> apps and thus get them fixed. On Mon, Aug 30, 2004 at 01:48:35AM -0600, Erik Andersen wrote: > There is no question that using PAGE_SIZE should be considered > harmful. But this particular change to the linux-libc-headers > makes it easy for the common case (bog standard x86) folk to keep > using a fixed PAGE_SIZE value, and keep writing crap code which > is now _guaranteed_ to blow chunks on mips, x86_64, etc. > I think outright removal of PAGE_SIZE from user space may be a > much better choice, with some sortof #error perhaps... Wouldn't > it be better for the whole world if people would get errors like > foo.c:10:2: #error "Don't use PAGE_SIZE, use sysconf(_SC_PAGESIZE)" > making people actually fix their code? In general people #define PAGE_SIZE (getpagesize()) or some such. -- wli