* [PATCH] minix fix
@ 2004-08-20 21:21 Andries.Brouwer
2004-08-30 1:52 ` [PATCH] minix fix - ? does this fix "du" bug ?!? Tom Oehser
0 siblings, 1 reply; 3+ messages in thread
From: Andries.Brouwer @ 2004-08-20 21:21 UTC (permalink / raw)
To: akpm, torvalds; +Cc: linux-kernel
In 2.5.18 some minix-specific stuff was moved to the minix
subdirectory where it belonged. However, a typo crept in.
A few people have complained, but so far not sufficiently loudly.
The bug is of a type that automated tools might discover:
a value res is computed, but not used.
Andries
Signed-off-by: Andries Brouwer
diff -uprN -X /linux/dontdiff a/fs/minixdiff -uprN -X /linux/dontdiff a/fs/minix/itree_common.c b/fs/minix/itree_common.c
--- a/fs/minix/itree_common.c 2003-12-18 03:59:05.000000000 +0100
+++ b/fs/minix/itree_common.c 2004-08-20 23:02:26.000000000 +0200
@@ -358,5 +358,5 @@ static inline unsigned nblocks(loff_t si
res += blocks;
direct = 1;
}
- return blocks;
+ return res;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] minix fix - ? does this fix "du" bug ?!?
2004-08-20 21:21 [PATCH] minix fix Andries.Brouwer
@ 2004-08-30 1:52 ` Tom Oehser
2004-08-30 15:19 ` Andries Brouwer
0 siblings, 1 reply; 3+ messages in thread
From: Tom Oehser @ 2004-08-30 1:52 UTC (permalink / raw)
To: Andries.Brouwer; +Cc: akpm, torvalds, linux-kernel
Will this patch fix the fact that 'du' is broken on minix, as a
few of us have been reporting? (Assume yes: Yippeedoo! Thanks!) -Tom
> In 2.5.18 some minix-specific stuff was moved to the minix
> subdirectory where it belonged. However, a typo crept in.
> A few people have complained, but so far not sufficiently loudly.
>
> The bug is of a type that automated tools might discover:
> a value res is computed, but not used.
>
> Andries
>
> Signed-off-by: Andries Brouwer
>
> diff -uprN -X /linux/dontdiff a/fs/minixdiff -uprN -X /linux/dontdiff a/fs/minix/itree_common.c b/fs/minix/itree_common.c
> --- a/fs/minix/itree_common.c 2003-12-18 03:59:05.000000000 +0100
> +++ b/fs/minix/itree_common.c 2004-08-20 23:02:26.000000000 +0200
> @@ -358,5 +358,5 @@ static inline unsigned nblocks(loff_t si
> res += blocks;
> direct = 1;
> }
> - return blocks;
> + return res;
> }
> -
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-08-30 15:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-08-20 21:21 [PATCH] minix fix Andries.Brouwer
2004-08-30 1:52 ` [PATCH] minix fix - ? does this fix "du" bug ?!? Tom Oehser
2004-08-30 15:19 ` Andries Brouwer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox