public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Johannes Stezenbach <js@linuxtv.org>
To: Jacek Pop?awski <jacekpoplawski@wp.pl>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: 2.6.19-rc1 stv0299 fix
Date: Mon, 30 Aug 2004 19:52:15 +0200	[thread overview]
Message-ID: <20040830175215.GA15303@convergence.de> (raw)
In-Reply-To: <20040830075244.GA166@bokowka>

On Mon, Aug 30, 2004 at 07:52:44AM +0000, Jacek Pop?awski wrote:
> 
> I use SkyStar 2.6c DVB card. I noticed that I can't watch digital television
> anymore, after 2.6.7 to 2.6.9-rc1 upgrade. First reason was change of DVB
> device, but second one is little bug in kernel.
> 
> Name of device has been changed in 2.6.9-rc1 to "SkyStar2", but module stv0299
> still compares name with "Technisat SkyStar2 driver", strings are different,
> and result is that stv0299 detects invalid tuner type. Not only I am not able
> to tune anything, but also I can crash system just by reloading DVB modules and
> being in X at same time.

How so? What does the DVB driver have to do with X?

> Following obvious patch fixes problem.

Patch looks good. Please apply.

Johannes


--- linux-2.6.9-rc1/drivers/media/dvb/frontends/stv0299.c	2004-08-25 21:40:56.000000000 +0200
+++ linux/drivers/media/dvb/frontends/stv0299.c	2004-08-30 02:08:00.902739808 +0200
@@ -1271,7 +1271,7 @@
 
 	printk ("%s: try to attach to %s\n", __FUNCTION__, adapter->name);
 
-	if ( strcmp(adapter->name, "Technisat SkyStar2 driver") == 0 )
+	if ( strcmp(adapter->name, "SkyStar2") == 0 )
 	{
 	    printk ("%s: setup for tuner Samsung TBMU24112IMB\n", __FILE__)



      reply	other threads:[~2004-08-30 17:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-30  7:52 2.6.19-rc1 stv0299 fix Jacek Popławski
2004-08-30 17:52 ` Johannes Stezenbach [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040830175215.GA15303@convergence.de \
    --to=js@linuxtv.org \
    --cc=akpm@osdl.org \
    --cc=jacekpoplawski@wp.pl \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox