Re: [PATCH 2.4] - Fixes bug in fs/ext3/super.c.

[Marcelo Tosatti <marcelo.tosatti@cyclades.com>]

On Mon, Aug 30, 2004 at 12:47:24PM -0300, Luiz Fernando N. Capitulino wrote:
> 
>  Hi Marcelo,
> 
>   Some time ago I fixed this bug in 2.6.
> 
>   There is a `return NULL' missing in ext3_get_journal() if the
>  call to journal_init_inode() fail. Note that if the error happens,
>  `journal' will be NULL and used.
> 
> (agains't 2.4.28-pre2).
> 
> Signed-off-by: Luiz Capitulino <lcapitulino@conectiva.com.br>
> 
> 
> diff -Nparu a/fs/ext3/super.c a~/fs/ext3/super.c
> --- a/fs/ext3/super.c	2004-08-07 20:26:05.000000000 -0300
> +++ a~/fs/ext3/super.c	2004-08-15 22:18:18.000000000 -0300
> @@ -1302,6 +1302,7 @@ static journal_t *ext3_get_journal(struc
>  	if (!journal) {
>  		printk(KERN_ERR "EXT3-fs: Could not load journal inode\n");
>  		iput(journal_inode);
> +		return NULL;
>  	}
>  	ext3_init_journal_params(EXT3_SB(sb), journal);
>  	return journal;

Applied, 

thanks.