Re: [PATCH] cleanup ptrace stops and remove notify_parent

[Daniel Jacobowitz <dan@debian.org>]

On Tue, Aug 31, 2004 at 10:19:04PM +0900, OGAWA Hirofumi wrote:
> Linus Torvalds <torvalds@osdl.org> writes:
> 
> > Ok, I definitely agree with the approach
> 
> I agree with that approach.
> 
> > Looks pretty clean as an implementation. The question is whether we should 
> > aim for 2.6.9 or 2.6.10 - if the first, then I should probably take it 
> > now, otherwise it should go into -mm first and be merged early after 2.6.9 
> > has been released, for the first -rc.
> > 
> > I _looks_ pretty safe, and it's hopefully much less likely to have subtle
> > bugs and races than our old approach had, but I have a hard time judging. 
> 
> Ptrace has several ugly things. And I'm thinking those needs
> user-visible change more or less to improve, like this.
> (->parent/wait4/child_list, PTRACE_SYSCALL/PTRACE_SINGLESTEP ...)
> 
> Should we also clean up and improve those with user-visible change?
> Those should be thought as separate issue?
> 
> I think we should be improved with new interface... (after it, we
> can deprecate ptrace)

I recommend the same thing I recommend every time this comes up: make
sure to take a look at how Solaris does this through /proc.  It seems
to be much nicer.

-- 
Daniel Jacobowitz