public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Antonino A. Daplas" <adaplas@hotpop.com>
To: Paolo Ornati <ornati@fastwebnet.it>, linux-kernel@vger.kernel.org
Subject: Re: 2.6.9-rc1: scrolling with tdfxfb 5 times slower
Date: Wed, 1 Sep 2004 07:29:07 +0800	[thread overview]
Message-ID: <200409010729.07156.adaplas@hotpop.com> (raw)
In-Reply-To: <200408312133.40039.ornati@fastwebnet.it>

On Wednesday 01 September 2004 03:33, Paolo Ornati wrote:
> Tests with "linux/MAINTAINERS" (time cat MAINTAINERS)
> 2.6.8.1
> 	real    0m2.625s
> 	user    0m0.000s
> 	sys     0m2.621s
>
> 2.6.9-rc1
> 	real    0m13.528s
> 	user    0m0.000s
> 	sys     0m13.553s
>
>
> Also many -mm kernels are affected... this is obvious because these patches
> come from Andrew's tree ;-)
>

Try this patch also, but select Y for CONFIG_FB_3DFX_ACCEL.  You also need
to revert info->flags to FBINFO_DEFAULT | FBINFO_HWACCEL_YPAN;

Tony

diff -uprN linux-2.6.9-rc1-mm1-orig/drivers/video/tdfxfb.c linux-2.6.9-rc1-mm1/drivers/video/tdfxfb.c
--- linux-2.6.9-rc1-mm1-orig/drivers/video/tdfxfb.c	2004-08-30 19:39:19.000000000 +0800
+++ linux-2.6.9-rc1-mm1/drivers/video/tdfxfb.c	2004-09-01 07:23:12.855078672 +0800
@@ -168,7 +168,6 @@ static int banshee_wait_idle(struct fb_i
 static void tdfxfb_fillrect(struct fb_info *info, const struct fb_fillrect *rect);
 static void tdfxfb_copyarea(struct fb_info *info, const struct fb_copyarea *area);  
 static void tdfxfb_imageblit(struct fb_info *info, const struct fb_image *image); 
-static int tdfxfb_cursor(struct fb_info *info, struct fb_cursor *cursor);
 #endif /* CONFIG_FB_3DFX_ACCEL */
 
 static struct fb_ops tdfxfb_ops = {
@@ -183,13 +182,12 @@ static struct fb_ops tdfxfb_ops = {
 	.fb_fillrect	= tdfxfb_fillrect,
 	.fb_copyarea	= tdfxfb_copyarea,
 	.fb_imageblit	= tdfxfb_imageblit,
-	.fb_cursor	= tdfxfb_cursor,
 #else
 	.fb_fillrect	= cfb_fillrect,
 	.fb_copyarea	= cfb_copyarea,
 	.fb_imageblit	= cfb_imageblit,
-	.fb_cursor	= soft_cursor,
 #endif
+	.fb_cursor	= soft_cursor,
 };
 
 /*
@@ -1030,7 +1028,9 @@ static void tdfxfb_imageblit(struct fb_i
 	}
 	banshee_wait_idle(info);
 }
+#endif /* CONFIG_FB_3DFX_ACCEL */
 
+#ifdef TDFX_HARDWARE_CURSOR
 static int tdfxfb_cursor(struct fb_info *info, struct fb_cursor *cursor)
 {
 	struct tdfx_par *par = (struct tdfx_par *) info->par;
@@ -1167,7 +1167,7 @@ static int tdfxfb_cursor(struct fb_info 
 	spin_unlock_irqrestore(&par->DAClock, flags);
 	return 0;
 }
-#endif /* CONFIG_FB_3DFX_ACCEL */
+#endif
 
 /**
  *      tdfxfb_probe - Device Initializiation



  parent reply	other threads:[~2004-09-01  0:02 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-08-31 19:33 2.6.9-rc1: scrolling with tdfxfb 5 times slower Paolo Ornati
2004-08-31 20:28 ` Antonino A. Daplas
2004-09-01  7:10   ` Paolo Ornati
2004-08-31 23:29 ` Antonino A. Daplas [this message]
2004-09-01  7:20   ` Paolo Ornati
2004-09-01 10:21     ` Antonino A. Daplas
2004-09-01 10:51       ` Antonino A. Daplas
2004-09-01 11:55         ` Paolo Ornati
2004-09-01 20:10           ` Antonino A. Daplas
2004-09-02  9:23             ` Paolo Ornati
2004-09-02 12:20               ` Antonino A. Daplas
2004-09-02 17:10                 ` Paolo Ornati
2004-09-02 19:52                   ` Antonino A. Daplas
2004-09-01 20:20           ` Antonino A. Daplas
2004-09-02  9:26             ` Paolo Ornati
2004-09-01 11:48       ` Paolo Ornati
2004-09-01  1:21 ` David S. Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200409010729.07156.adaplas@hotpop.com \
    --to=adaplas@hotpop.com \
    --cc=adaplas@pol.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ornati@fastwebnet.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox