From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S266898AbUIAPh0 (ORCPT ); Wed, 1 Sep 2004 11:37:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S266894AbUIAPh0 (ORCPT ); Wed, 1 Sep 2004 11:37:26 -0400 Received: from holomorphy.com ([207.189.100.168]:18630 "EHLO holomorphy.com") by vger.kernel.org with ESMTP id S266914AbUIAPgd (ORCPT ); Wed, 1 Sep 2004 11:36:33 -0400 Date: Wed, 1 Sep 2004 08:36:24 -0700 From: William Lee Irwin III To: Kirill Korotaev Cc: akpm@osdl.org, torvalds@osdl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] obscure pid implementation fix (v2) Message-ID: <20040901153624.GA5492@holomorphy.com> Mail-Followup-To: William Lee Irwin III , Kirill Korotaev , akpm@osdl.org, torvalds@osdl.org, linux-kernel@vger.kernel.org References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: The Domain of Holomorphy User-Agent: Mutt/1.5.6+20040722i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 01, 2004 at 03:46:07PM +0400, Kirill Korotaev wrote: > I remade the previous patch against the latest Linus tree, please apply. > This patch fixes strange and obscure pid implementation in current kernels: > - it removes calling of put_task_struct() from detach_pid() > under tasklist_lock. This allows to use blocking calls > in security_task_free() hooks (in __put_task_struct()). > - it saves some space = 5*5 ints = 100 bytes in task_struct > - it's smaller and tidy, more straigthforward and doesn't use > any knowledge about pids using and assignment. > - it removes pid_links and pid_struct doesn't hold reference counters > on task_struct. instead, new pid_structs and linked altogether and > only one of them is inserted in hash_list. > Signed-off-by: Kirill Korotaev (kksx@mail.ru) Could you not rename struct pid and not rename for_each_task_pid()? Thanks. -- wli