From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S267364AbUIARcy (ORCPT ); Wed, 1 Sep 2004 13:32:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S267376AbUIARcs (ORCPT ); Wed, 1 Sep 2004 13:32:48 -0400 Received: from holomorphy.com ([207.189.100.168]:60358 "EHLO holomorphy.com") by vger.kernel.org with ESMTP id S267364AbUIARac (ORCPT ); Wed, 1 Sep 2004 13:30:32 -0400 Date: Wed, 1 Sep 2004 10:30:27 -0700 From: William Lee Irwin III To: Kirill Korotaev Cc: akpm@osdl.org, torvalds@osdl.org, linux-kernel@vger.kernel.org Subject: [3/7] make do_each_task_pid()/while_each_task_pid() parenthesize their arguments Message-ID: <20040901173027.GG5492@holomorphy.com> Mail-Followup-To: William Lee Irwin III , Kirill Korotaev , akpm@osdl.org, torvalds@osdl.org, linux-kernel@vger.kernel.org References: <20040901153624.GA5492@holomorphy.com> <20040901165808.GD5492@holomorphy.com> <20040901172710.GE5492@holomorphy.com> <20040901172839.GF5492@holomorphy.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040901172839.GF5492@holomorphy.com> Organization: The Domain of Holomorphy User-Agent: Mutt/1.5.6+20040722i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 01, 2004 at 10:28:39AM -0700, William Lee Irwin III wrote: > do { ... } while () -like constructs require semicolons to follow them. > This patch arranges for do_each_task_pid() { ... } while_each_task_pid() > to do likewise. Macros must parenthesize their arguments when they appear as expressions not surrounded by other bracketing symbols. This patch parenthesizes the task argument to do_each_task_pid() and while_each_task_pid() where needed. This kind of iteration macro doesn't need multiple evaluation fixes. Index: kirill-2.6.9-rc1-mm2/include/linux/pid.h =================================================================== --- kirill-2.6.9-rc1-mm2.orig/include/linux/pid.h 2004-09-01 09:01:13.653422464 -0700 +++ kirill-2.6.9-rc1-mm2/include/linux/pid.h 2004-09-01 09:07:48.266432168 -0700 @@ -43,14 +43,14 @@ #define do_each_task_pid(who, type, task) \ do { \ if ((task = find_task_by_pid_type(type, who))) { \ - prefetch(task->pids[type].pid_list.next); \ + prefetch((task)->pids[type].pid_list.next); \ do { #define while_each_task_pid(who, type, task) \ - task = pid_task(task->pids[type].pid_list.next, \ + task = pid_task((task)->pids[type].pid_list.next,\ type); \ - prefetch(task->pids[type].pid_list.next); \ - } while (task->pids[type].hash_list.next); \ + prefetch((task)->pids[type].pid_list.next); \ + } while ((task)->pids[type].hash_list.next); \ } \ } while (0)