From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263024AbUIAI14 (ORCPT ); Wed, 1 Sep 2004 04:27:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263795AbUIAI1z (ORCPT ); Wed, 1 Sep 2004 04:27:55 -0400 Received: from launch.server101.com ([216.218.196.178]:5848 "EHLO mail-pop3-1.server101.com") by vger.kernel.org with ESMTP id S263024AbUIAI1x convert rfc822-to-8bit (ORCPT ); Wed, 1 Sep 2004 04:27:53 -0400 From: Tim Fairchild To: Linus Torvalds Subject: Re: K3b and 2.6.9? Date: Wed, 1 Sep 2004 18:27:42 +1000 User-Agent: KMail/1.6.1 Cc: ismail =?iso-8859-1?q?d=F6nmez?= , Alan Cox , Linux Kernel Mailing List References: <200408301047.06780.tim@bcs4me.com> <2a4f155d04083113162c2759ea@mail.gmail.com> In-Reply-To: MIME-Version: 1.0 Content-Disposition: inline Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT Message-Id: <200409011827.42576.tim@bcs4me.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday 01 Sep 2004 06:33, Linus Torvalds wrote: > On Tue, 31 Aug 2004, ismail dönmez wrote: > > Checked k3b on CVS and it does this now : > > > > int flags = O_NONBLOCK; > > if( write ) > > flags |= O_RDWR; > > else > > flags |= O_RDONLY; > > ..... > > fd = ::open( name, flags ); > > > > which already fixes the issue. Right? > > I assume so, assuming that the "write" flag is set correctly. Somebody > would need to test whether it actually works for them ;) I can't seem to easily get the cvs to compile on my box at the moment, but making these changes to the k3b-0.11.14 code seems to be working here, tho k3b seems to always open as write now. Haven't looked at latest dvd+rw-tools but they would be similar I guess... tim