From: William Lee Irwin III <wli@holomorphy.com>
To: Kirill Korotaev <kksx@mail.ru>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fixed pidhashing patch
Date: Thu, 2 Sep 2004 11:20:14 -0700 [thread overview]
Message-ID: <20040902182014.GG5492@holomorphy.com> (raw)
In-Reply-To: <E1C2ppG-0003xU-00.kksx-mail-ru@f16.mail.ru>
On Thu, Sep 02, 2004 at 03:32:22PM +0400, Kirill Korotaev wrote:
> I cleanuped it once again. It compiles/works fine.
> Hope there will be no more problems with it.
> list of small changes:
> - FIXED bug in do_each_task_pid() made by Lee. last task was skipped in the loop, removed __list__ var.
> - remade patch against latest tree (there was a conflict in exit.c)
> - returned 'extern' in find_pid() declaration
> - fixed style a bit in detach_pid(), find_task_by_pid_type()
Heh, looks like I flubbed the loop condition too. For some reason I
thought pid_list was headed at the leader instead of being headerless,
which upon a rereading I see now, so explaining my confusion there.
The semicolon-requiring bits don't appear to be used by any of the
other do { ... } while(...) -style iterators, so I won't press that.
This patch appears sound and stylistically good. Linus, please add:
Signed-off-by: William Irwin <wli@holomorphy.com>
-- wli
prev parent reply other threads:[~2004-09-02 18:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-09-02 11:32 [PATCH] fixed pidhashing patch Kirill Korotaev
2004-09-02 18:20 ` William Lee Irwin III [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040902182014.GG5492@holomorphy.com \
--to=wli@holomorphy.com \
--cc=akpm@osdl.org \
--cc=kksx@mail.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox