From: Dave Jones <davej@redhat.com>
To: len.brown@intel.com
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Pointer dereference before NULL check in ACPI thermal driver.
Date: Fri, 3 Sep 2004 22:13:11 +0100 [thread overview]
Message-ID: <20040903211311.GX26419@redhat.com> (raw)
Again, found with coverity's checker.
Signed-off-by: Dave Jones <davej@redhat.com>
--- linux-2.6.8/drivers/acpi/thermal.c~ 2004-09-03 22:11:22.630428496 +0100
+++ linux-2.6.8/drivers/acpi/thermal.c 2004-09-03 22:11:44.392120216 +0100
@@ -659,7 +659,7 @@
struct acpi_thermal *tz = (struct acpi_thermal *) data;
unsigned long sleep_time = 0;
int i = 0;
- struct acpi_thermal_state state = tz->state;
+ struct acpi_thermal_state state;
ACPI_FUNCTION_TRACE("acpi_thermal_check");
@@ -668,6 +668,8 @@
return_VOID;
}
+ state = tz->state;
+
result = acpi_thermal_get_temperature(tz);
if (result)
return_VOID;
reply other threads:[~2004-09-03 21:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040903211311.GX26419@redhat.com \
--to=davej@redhat.com \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox